From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [GIT PULL] remaining tpmdd fixes for Linux 4.5 Date: Mon, 22 Feb 2016 16:50:23 +0200 Message-ID: <20160222145023.GA28365@intel.com> References: <20160220081705.GA12981@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: James Morris Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, keyrings-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wilck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net T24gTW9uLCBGZWIgMjIsIDIwMTYgYXQgMTI6NTY6NTNQTSArMTEwMCwgSmFtZXMgTW9ycmlzIHdy b3RlOgo+IE9uIFNhdCwgMjAgRmViIDIwMTYsIEphcmtrbyBTYWtraW5lbiB3cm90ZToKPiAKPiA+ IEhpIEphbWVzLAo+ID4gCj4gPiBJJ20gc29ycnkgZm9yIHRoZSBsYXRlIHB1bGwgcmVxdWVzdCBm b3IgNC41LiBUaGUgcmVhc29uIGZvciB0aGlzIHdhcwo+ID4gdGhlIGxhdGVuY3kgaW4gbXkgcHJl dmlvdXMgb25lLiBJIHBpY2tlZCB3aXRoIGNhcmUgdGhlIGFic29sdXRlbHkKPiA+IGNyaXRpY2Fs IGZpeGVzIHNvIHRoYXQgd2UgY2FuIG1ha2UgYSBzb3VuZCB0cG1kZCByZWxlYXNlLgo+ID4gCj4g PiBJIHJlYWxseSBob3BlIHlvdSBjYW4gc3RpbGwgcGljayB0aGVzZSBhcyBvbmUgb2YgdGhlbSBp cyBhYnNvbHV0ZWx5Cj4gPiBjcml0aWNhbCB0byBnZXQgYXV0aG9yaXphdGlvbiBwb2xpY3kgc2Vh bGluZyBBUEkgcmlnaHQgKGtlcm5lbCBrZWVwcwo+ID4gaXQgZmluZ2VyIG91dCBvZiB1c2VyIHNw YWNlIGNyZWF0ZWQgb2JqZWN0cykuCj4gCj4gUHVzaGVkIHRvIG5leHQgZm9yIG1vcmUgdGVzdGlu ZyBhbmQgcmV2aWV3Lgo+IAo+IFRoaXMgcmVhbGx5IGlzIGdldHRpbmcgdG9vIGxhdGUgaW4gdGhl IGRldmVsb3BtZW50IGN5Y2xlIGZvciBzbyBtYW55IAo+IGZpeGVzLiAgSXQgbWVhbnMgdGhlIGNv ZGUgd2FzIG5vdCByZWFkeSB0byBiZSBtZXJnZWQgaW4gdGhlIGZpcnN0IHBsYWNlLgoKSSBmdWxs eSBhZ3JlZSB3aGF0IHlvdSdyZSBzYXlpbmcuIEknbGwgbGVhcm4gdGhlIGxlc3NvbiBoZXJlIGFu ZCB0YWtlCmZhY3RvcnMgbW9yZSBjb25zZXJ2YXRpdmUgYXR0aXR1ZGUgZnJvbSBub3cgb24uIE5v IGV4Y3VzZXMuIEknbSBzb3JyeQphYm91dCB0aGlzLgoKUGFydGx5IHRoZSByZWFzb24gZm9yIHJl Y2VudCBpbmNyZWFzZSBpbiByZWdyZXNzaW9ucyBoYXMgYmVlbgppbmNyZWFzZWQgcmVhbC13b3Js ZCB1c2Ugb2YgVFBNMiBhbmQgdGh1cyBpc3N1ZXMgaGF2ZSBzdGFydGVkIHRvIHBvcAp1cCB0aGF0 J3MgYSBsYW1lIGV4Y3VzZSBhbnl3YXkuCgo+IEFsc28sIGFueSBpZGVhIHdoeSBJJ20gc2VlaW5n IHRoaXM6Cj4gCj4gZHJpdmVycy9jaGFyL3RwbS90cG1fdGlzLmM6ODM4OiB3YXJuaW5nOiDigJh0 cG1fdGlzX3Jlc3VtZeKAmSBkZWZpbmVkIGJ1dCBub3QgCj4gdXNlZAoKQmlzZWN0ZWQgdGhlIHBh dGNoOiAwMDE5NDgyNmU2YmUKCkRvIHlvdSB3YW50IG1lIHRvIHNlbmQgYSBwdWxsIHJlcXVlc3Qg Y29udGFpbmluZyBhIGZpeCBmb3IgdGhlIGJ1aWxkCndhcm5pbmcgb3IgcmV2ZXJ0aW5nIHRoZSB3 aG9sZSBjb21taXQ/IE15IGNhbGwgd291bGQgYmUgdG8gYXBwbHkgdGhlCmZpeCBiZWNhdXNlIHRo aXMgY29tbWl0IGhhcyBiZWVuIHRlc3RlZCBib3RoIFRQTSAxLjIgYnkgTWFydGluIGFuZAp3aXRo IFRQTSAyLjAgYnkgbWUgYW5kIHRoaW5ncyBoYXZlIHdvcmtlZCB3ZWxsLgoKSSBjYW4gbGl2ZSB3 aXRoIGVpdGhlciBvcHRpb24uCgpJIGFscmVhZHkgcHVzaGVkIGEgZml4IHRvIG15IG1hc3RlciBm b3IgdGhpcyBpc3N1ZToKCmh0dHBzOi8vZ2l0aHViLmNvbS9qc2Fra2luZS9saW51eC10cG1kZC9j b21taXQvNjM4NjU0NGFkN2JjZWIzZDAyNDhiODVkYTI5ZDRkOTllZWJlOTE2MQoKPiAtLSAKPiBK YW1lcyBNb3JyaXMKPiA8am1vcnJpc0BuYW1laS5vcmc+CgpJJ3ZlIGJlZW4gcmVjZW50bHkgd29y a2luZyBvbiBhIGN1c3RvbSBCUiBlbnZpcm9ubWVudCB0aGF0IGJ1bmRsZXMgbXkKbGF0ZXN0IG1h c3RlciB3aXRoIGluaXRyYW1mcyB1c2VyIHNwYWNlIFsxXS4gQXQgbWluaW11bSBJJ2xsIHN0YXJ0 CnVzaW5nIHRoaXMgZW52aXJvbm1lbnQgdG8gY3JlYXRlIGJ1aWxkcyBvZiB0aGlzIGVudiB3aXRo IGFuZCB3aXRob3V0ClBNIGZvciByZWxlYXNlIHRlc3RpbmcgYW5kIHJ1biB0aGUgaW1hZ2VzIGJv dGggMS4yIGFuZCAyLjAgSFcuCgpUaGlzIHNob3VsZCBwcmV2ZW50IHRoZSB3YXJuaW5nIHlvdSBl eHBlcmllbmNlZCBuZXZlciBoYXBwZW5pbmcgYWdhaW4uCgpbMV0gIGh0dHA6Ly9naXQuaW5mcmFk ZWFkLm9yZy91c2Vycy9qanMvYnVpbGRyb290LXRwbWRkLmdpdAoKL0phcmtrbwoKLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tClNpdGUyNHg3IEFQTSBJbnNpZ2h0OiBHZXQgRGVlcCBWaXNpYmlsaXR5IGlu dG8gQXBwbGljYXRpb24gUGVyZm9ybWFuY2UKQVBNICsgTW9iaWxlIEFQTSArIFJVTTogTW9uaXRv ciAzIEFwcCBpbnN0YW5jZXMgYXQganVzdCAkMzUvTW9udGgKTW9uaXRvciBlbmQtdG8tZW5kIHdl YiB0cmFuc2FjdGlvbnMgYW5kIHRha2UgY29ycmVjdGl2ZSBhY3Rpb25zIG5vdwpUcm91Ymxlc2hv b3QgZmFzdGVyIGFuZCBpbXByb3ZlIGVuZC11c2VyIGV4cGVyaWVuY2UuIFNpZ251cCBOb3chCmh0 dHA6Ly9wdWJhZHMuZy5kb3VibGVjbGljay5uZXQvZ2FtcGFkL2Nsaz9pZD0yNzI0ODcxNTEmaXU9 LzQxNDAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KdHBt ZGQtZGV2ZWwgbWFpbGluZyBsaXN0CnRwbWRkLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldApo dHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby90cG1kZC1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752134AbcBVOuh (ORCPT ); Mon, 22 Feb 2016 09:50:37 -0500 Received: from mga09.intel.com ([134.134.136.24]:41334 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752200AbcBVOuc (ORCPT ); Mon, 22 Feb 2016 09:50:32 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,484,1449561600"; d="scan'208";a="657166518" Date: Mon, 22 Feb 2016 16:50:23 +0200 From: Jarkko Sakkinen To: James Morris Cc: linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, Wilck@intel.com, Martin , Jason Gunthorpe Subject: Re: [GIT PULL] remaining tpmdd fixes for Linux 4.5 Message-ID: <20160222145023.GA28365@intel.com> References: <20160220081705.GA12981@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 22, 2016 at 12:56:53PM +1100, James Morris wrote: > On Sat, 20 Feb 2016, Jarkko Sakkinen wrote: > > > Hi James, > > > > I'm sorry for the late pull request for 4.5. The reason for this was > > the latency in my previous one. I picked with care the absolutely > > critical fixes so that we can make a sound tpmdd release. > > > > I really hope you can still pick these as one of them is absolutely > > critical to get authorization policy sealing API right (kernel keeps > > it finger out of user space created objects). > > Pushed to next for more testing and review. > > This really is getting too late in the development cycle for so many > fixes. It means the code was not ready to be merged in the first place. I fully agree what you're saying. I'll learn the lesson here and take factors more conservative attitude from now on. No excuses. I'm sorry about this. Partly the reason for recent increase in regressions has been increased real-world use of TPM2 and thus issues have started to pop up that's a lame excuse anyway. > Also, any idea why I'm seeing this: > > drivers/char/tpm/tpm_tis.c:838: warning: ‘tpm_tis_resume’ defined but not > used Bisected the patch: 00194826e6be Do you want me to send a pull request containing a fix for the build warning or reverting the whole commit? My call would be to apply the fix because this commit has been tested both TPM 1.2 by Martin and with TPM 2.0 by me and things have worked well. I can live with either option. I already pushed a fix to my master for this issue: https://github.com/jsakkine/linux-tpmdd/commit/6386544ad7bceb3d0248b85da29d4d99eebe9161 > -- > James Morris > I've been recently working on a custom BR environment that bundles my latest master with initramfs user space [1]. At minimum I'll start using this environment to create builds of this env with and without PM for release testing and run the images both 1.2 and 2.0 HW. This should prevent the warning you experienced never happening again. [1] http://git.infradead.org/users/jjs/buildroot-tpmdd.git /Jarkko