From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/4] arm64: prevent potential circular header dependencies in asm/bug.h
Date: Mon, 22 Feb 2016 18:00:57 +0000 [thread overview]
Message-ID: <20160222180056.GN31168@arm.com> (raw)
In-Reply-To: <1455289046-21321-4-git-send-email-ard.biesheuvel@linaro.org>
On Fri, Feb 12, 2016 at 03:57:25PM +0100, Ard Biesheuvel wrote:
> Currently, using BUG_ON() in header files is cumbersome, due to the fact
> that asm/bug.h transitively includes a lot of other header files, resulting
> in the actual BUG_ON() invocation appearing before its definition in the
> preprocessor input. So let's reverse the #include dependency between
> asm/bug.h and asm/debug-monitors.h, by moving the definition of BUG_BRK_IMM
> from the latter to the former. Also fix up one user of asm/debug-monitors.h
> which relied on a transitive include.
>
> Cc: Dave Martin <Dave.Martin@arm.com>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> arch/arm64/include/asm/bug.h | 2 +-
> arch/arm64/include/asm/debug-monitors.h | 2 +-
> arch/arm64/kvm/hyp/debug-sr.c | 1 +
> 3 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/include/asm/bug.h b/arch/arm64/include/asm/bug.h
> index 4a748ce9ba1a..679d49221998 100644
> --- a/arch/arm64/include/asm/bug.h
> +++ b/arch/arm64/include/asm/bug.h
> @@ -18,7 +18,7 @@
> #ifndef _ARCH_ARM64_ASM_BUG_H
> #define _ARCH_ARM64_ASM_BUG_H
>
> -#include <asm/debug-monitors.h>
> +#define BUG_BRK_IMM 0x800
I'd really like to keep all the BRK immediates together, otherwise it's
error-prone if/when we allocate new encodings. Maybe we could add a new
header file for them, if we really need to?
Alternatively, given that this is all behind DEBUG_VM, you could rewrite
the check as if (unlikely(...)) panic(...);
Will
next prev parent reply other threads:[~2016-02-22 18:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 14:57 [PATCH v3 0/4] arm64: avoid early __va translations Ard Biesheuvel
2016-02-12 14:57 ` [PATCH v3 1/4] of/fdt: factor out assignment of initrd_start/initrd_end Ard Biesheuvel
2016-02-22 16:49 ` Will Deacon
2016-02-22 16:56 ` Ard Biesheuvel
2016-02-22 17:09 ` Will Deacon
2016-02-22 17:16 ` Ard Biesheuvel
2016-02-12 14:57 ` [PATCH v3 2/4] arm64: defer __va translation of initrd_start and initrd_end Ard Biesheuvel
2016-02-12 14:57 ` [PATCH v3 3/4] arm64: prevent potential circular header dependencies in asm/bug.h Ard Biesheuvel
2016-02-22 18:00 ` Will Deacon [this message]
2016-02-12 14:57 ` [PATCH v3 4/4] arm64: prevent __va() translations before memstart_addr is assigned Ard Biesheuvel
2016-02-22 16:52 ` Will Deacon
2016-02-22 17:17 ` Ard Biesheuvel
2016-02-22 17:41 ` Catalin Marinas
2016-02-22 17:55 ` Ard Biesheuvel
2016-02-22 17:26 ` Catalin Marinas
2016-02-22 17:38 ` Ard Biesheuvel
2016-02-15 10:42 ` [PATCH v3 0/4] arm64: avoid early __va translations Laurentiu Tudor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222180056.GN31168@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.