Re: [Outreachy kernel] [PATCH 4/5] Staging: lustre: Use min_t or max_t instead of ternary operator

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Feb 22, 2016 at 04:15:33PM +0530, Bhumika Goyal wrote:
> Replace ternary operators with macros min_t/max_t as they are 
> shorter and thus increases code readability. Macro min_t return the minimum
> and min_t returns maximum of the two compared values.
> Made a semantic patch for changes:
> 
> @@
> type T;
> T x;
> T y;
> @@
> (
> - x < y ? x : y
> + min_t(T,x,y)
> |
> - x > y ? x : y
> + max_t(T,x,y)
> )

If they are the same type, why can't you just use min() and max()?  The
call to min_t() and max_t() seem a bit of an overkill as they do an
explicit cast for when the types of the two variables are not the same
type.

So I'd prefer this patch to just be min() and max() if at all possible.

thanks,

greg k-h