From: Greg KH <gregkh@linuxfoundation.org>
To: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: lustre: obdclass: Replace simple_strtoul with kstrtoul
Date: Mon, 22 Feb 2016 13:12:29 -0800 [thread overview]
Message-ID: <20160222211229.GC5849@kroah.com> (raw)
In-Reply-To: <20160222123259.GA24119@amitoj-Inspiron-3542>
On Mon, Feb 22, 2016 at 06:02:59PM +0530, Amitoj Kaur Chawla wrote:
> Replace obsolete simple_strtoul with kstrtoul.
> The Coccinelle semantic patch used to make this change is as follows:
>
> // <smpl>
> @@
> unsigned long l;
> expression e,f,g;
> @@
> - l = simple_strtoul(e, &f, g)
> + kstrtoul(e, g, &l)
> // </smpl>
As you are finding out, it's not as simple as this for this type of
conversion, which is why we haven't just swept the whole kernel tree by
now and done this :(
sorry,
greg k-h
prev parent reply other threads:[~2016-02-22 21:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 12:32 [PATCH] staging: lustre: obdclass: Replace simple_strtoul with kstrtoul Amitoj Kaur Chawla
2016-02-22 12:36 ` [Outreachy kernel] " Julia Lawall
2016-02-22 12:40 ` Amitoj Kaur Chawla
2016-02-22 12:42 ` Julia Lawall
2016-02-22 21:12 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222211229.GC5849@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amitoj1606@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.