All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vincent Stehlé" <vincent.stehle@intel.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] msr-tools: new package
Date: Mon, 22 Feb 2016 23:21:52 +0100	[thread overview]
Message-ID: <20160222222152.GA22228@jazz.nc.intel.com> (raw)
In-Reply-To: <CAGm1_kuNhAYrMRf_T3FU5gCoYYT72nEm=MeTRWkdo9FrYjK9-g@mail.gmail.com>

Hi Yegor,

Thank you very much for your review!

On Mon, Feb 22, 2016 at 03:40:59PM +0100, Yegor Yefremov wrote:
> 
> Config.in is missing a depends message like this:
> 
> comment "msr-tools runs only on x86 CPUs"
>         depends on !BR2_i386 && !BR2_x86_64

Good idea; I'll add that.

..
> > +MSR_TOOLS_SOURCE = msr-tools-$(MSR_TOOLS_VERSION).tar.gz
> 
> Do you really need MSR_TOOLS_SOURCE?

And you are right again: this is definitely not necessary to repeat the default
source name :)

Thanks for spotting those; I'll send a v2 right away.

Best regards,

Vincent.

  reply	other threads:[~2016-02-22 22:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29 17:11 [Buildroot] [PATCH] msr-tools: new package Vincent Stehlé
2016-02-22 14:40 ` Yegor Yefremov
2016-02-22 22:21   ` Vincent Stehlé [this message]
2016-02-22 22:31     ` [Buildroot] [PATCH v2] " Vincent Stehlé
2016-02-23  0:22       ` Arnout Vandecappelle
2016-02-28 21:12         ` [Buildroot] [PATCH v3] " Vincent Stehlé
2016-02-28 21:32           ` Thomas Petazzoni
2016-02-23  0:13   ` [Buildroot] [PATCH] " Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160222222152.GA22228@jazz.nc.intel.com \
    --to=vincent.stehle@intel.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.