From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756299AbcBVXMh (ORCPT ); Mon, 22 Feb 2016 18:12:37 -0500 Received: from mx2.suse.de ([195.135.220.15]:41120 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755726AbcBVXMg (ORCPT ); Mon, 22 Feb 2016 18:12:36 -0500 Date: Tue, 23 Feb 2016 00:12:32 +0100 From: "Luis R. Rodriguez" To: Boris Ostrovsky Cc: Borislav Petkov , "Luis R. Rodriguez" , Juergen Gross , rusty@rustcorp.com.au, x86@kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, xen-devel@lists.xensource.com, david.vrabel@citrix.com Subject: Re: [Xen-devel] [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check Message-ID: <20160222231232.GD25240@wotan.suse.de> References: <1455887316-9223-1-git-send-email-mcgrof@kernel.org> <1455887316-9223-9-git-send-email-mcgrof@kernel.org> <56C71704.9080404@suse.com> <20160219144841.GP25240@wotan.suse.de> <20160222060756.GB25240@wotan.suse.de> <20160222102743.GB17895@pd.tnic> <56CB1C72.2000603@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56CB1C72.2000603@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 22, 2016 at 09:34:26AM -0500, Boris Ostrovsky wrote: > On 02/22/2016 05:27 AM, Borislav Petkov wrote: > >On Mon, Feb 22, 2016 at 07:07:56AM +0100, Luis R. Rodriguez wrote: > >>diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h > >>index 1ae89a2721d6..fe0d579b63e3 100644 > >>--- a/arch/x86/include/asm/x86_init.h > >>+++ b/arch/x86/include/asm/x86_init.h > >>@@ -84,11 +84,14 @@ struct x86_init_paging { > >> * boot cpu > >> * @timer_init: initialize the platform timer (default PIT/HPET) > >> * @wallclock_init: init the wallclock device > >>+ * @no_cmos_rtc: set when platform has no CMOS real-time clock > >>+ * present > >> */ > >> struct x86_init_timers { > >> void (*setup_percpu_clockev)(void); > >> void (*timer_init)(void); > >> void (*wallclock_init)(void); > >>+ bool no_cmos_rtc; > >I'd add > > > > u64 flags; > > > >to x86_init_ops and then set X86_PLATFORM_NO_RTC or so in there. The > >reason being, others could use that flags field too, for other stuff and > >define more bits. > > Maybe timer_flags or platform_flags (or something else) to be a > little more cscope-friendly? Sure, I'll go with platform_flags on x86_init_ops. Will repost a new series after 0-day testing. Luis