Re: RFC can-j1939

[Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>]

> 
> Dear Kurt,
> Thanks for your great work.
> I'm just bringing up the J1939 stack on a TI OMAP4 based system.
> I'm locked to a custom kernel 3.19 due to media drivers and codecs.
> I followed your guide and pulled code from 4.1 and 3.15 branches.

I guessed you just merge the j1939d-3.15 branch, noth the 4.1.

> I also patched and built can-utils and iproute2.

iproute2 must not be patched anymore.

> I can't get the Transport Protocol to work send only sends the first packet and receive hangs on reception of the first packet.

I walked through my quick starter guide and i realised I had not updated
it for dealing with the j1939 socket closing before the transport
protocol is ready.

I just now updated my quick start guide. Can you try that, and tell
where exactly it goes wrong in your opinion.

> As far as your RFC your implementation looks to be ideal for our applications.
> For user space applications where should the headers (<linux/can/can.h> & <linux/can/j1939/j1939.h>) be taken from or provided by?

Ideally, this becomes mainline and then you will sooner or later find
the header in linux/can/j1939.h. Up to then, you will need to fix your
toolchain manually by copying j1939.h there yourself.
Do not forget that linux/can.h needs patching too.

Kurt