From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: use proper type for failrec in extent_state
Date: Tue, 23 Feb 2016 12:34:07 +0100 [thread overview]
Message-ID: <20160223113407.GJ4374@suse.cz> (raw)
In-Reply-To: <56CBBEC3.8040106@cn.fujitsu.com>
On Tue, Feb 23, 2016 at 10:06:59AM +0800, Qu Wenruo wrote:
> > I'm not sure why, but my gcc 5.3.1 think's that a member of failrec can
> > be used uninitialized:
> >
> > CC [M] fs/btrfs/extent_io.o
> > fs/btrfs/extent_io.c: In function ‘clean_io_failure’:
> > fs/btrfs/extent_io.c:2133:4: warning: ‘failrec’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> > repair_io_failure(inode, start, failrec->len,
> > ^
> >
> After applying your patch on integration-4.6, and compiling, my gcc
> 5.3.0 didn't give such warning though.
>
> And I didn't see an official 5.3.1, but only 5.3 so I assume maybe it's
> related to the .1 from your distribution?
Yes it's distro gcc 5.3 + patches. Arnd sent a patch to fix the warning.
prev parent reply other threads:[~2016-02-23 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 12:24 [PATCH] btrfs: use proper type for failrec in extent_state David Sterba
2016-02-22 17:58 ` David Sterba
2016-02-23 2:06 ` Qu Wenruo
2016-02-23 11:34 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223113407.GJ4374@suse.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.