From: Pavel Machek <pavel@ucw.cz>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org, dedekind1@gmail.com,
adrian.hunter@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ubifs: Implement O_TMPFILE
Date: Tue, 23 Feb 2016 21:45:11 +0100 [thread overview]
Message-ID: <20160223204510.GA16961@amd> (raw)
In-Reply-To: <1456048004-20365-1-git-send-email-richard@nod.at>
Hi!
> + ui = ubifs_inode(inode);
> +
> + err = ubifs_init_security(dir, inode, &dentry->d_name);
> + if (err)
> + goto out_inode;
> +
> + mutex_lock(&ui->ui_mutex);
> + insert_inode_hash(inode);
> + d_tmpfile(dentry, inode);
> + ubifs_assert(ui->dirty);
> + instantiated = 1;
> + mutex_unlock(&ui->ui_mutex);
> +
> + mutex_lock(&dir_ui->ui_mutex);
> + err = ubifs_jnl_update(c, dir, &dentry->d_name, inode, 1, 0);
> + if (err)
> + goto out_cancel;
> + mutex_unlock(&dir_ui->ui_mutex);
Move the if () below unlock, and make it goto out_inode?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2016-02-23 20:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 9:46 [PATCH] ubifs: Implement O_TMPFILE Richard Weinberger
2016-02-23 20:45 ` Pavel Machek [this message]
2016-02-23 21:15 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223204510.GA16961@amd \
--to=pavel@ucw.cz \
--cc=adrian.hunter@intel.com \
--cc=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.