From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] vala: add vala/valac wrapper
Date: Tue, 23 Feb 2016 21:58:02 +0100 [thread overview]
Message-ID: <20160223215802.5f8348da@free-electrons.com> (raw)
In-Reply-To: <56CCB670.5000202@mind.be>
Arnout,
On Tue, 23 Feb 2016 20:43:44 +0100, Arnout Vandecappelle wrote:
> > So what *really* saves time is people reviewing and testing patches. Of
> > course, the more "trusted" those persons are, the more valuable this
> > effort is. Gustavo, you're a person with a high trust, but
> > unfortunately, you're doing none of this review/testing effort.
>
> There is one indirect gain, however. In case something needs to be fixed up
> (not quite the majority but still a significant subset of the patches), then
> Yann and I currently just give comments and wait for a v2 of the patch. This
> often leads to several iterations. Fixing the patch right away and pushing it
> will take less time.
This is true. One quick and simple workaround to this issue is that
when you are in such a situation, just pick-up the patch and resend it
for your minor fixes.
Of course, if the minor fix is really super trivial, then just indicate
it in your review, and Peter and I can fix that up. But if the
requested changes are a bit more significant, it does make sense to
resend the patch.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-23 20:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 16:01 [Buildroot] [PATCH 1/3] vala: add vala/valac wrapper Gustavo Zacarias
2016-02-02 16:01 ` [Buildroot] [PATCH 2/3] libgee: new package Gustavo Zacarias
2016-02-02 16:01 ` [Buildroot] [PATCH 3/3] granite: " Gustavo Zacarias
2016-02-21 21:28 ` [Buildroot] [PATCH 1/3] vala: add vala/valac wrapper Thomas Petazzoni
2016-02-22 1:22 ` Gustavo Zacarias
2016-02-22 23:47 ` Arnout Vandecappelle
2016-02-23 0:18 ` Gustavo Zacarias
2016-02-23 0:40 ` Arnout Vandecappelle
2016-02-23 1:06 ` Gustavo Zacarias
2016-02-23 9:42 ` Arnout Vandecappelle
2016-02-23 9:48 ` Thomas Petazzoni
2016-02-23 15:19 ` Peter Korsgaard
2016-02-23 19:43 ` Arnout Vandecappelle
2016-02-23 20:58 ` Thomas Petazzoni [this message]
2016-02-23 9:10 ` Thomas Petazzoni
2016-02-22 23:48 ` Arnout Vandecappelle
2016-02-23 0:27 ` Gustavo Zacarias
2016-02-23 0:30 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223215802.5f8348da@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.