From: Ralf Baechle <ralf@linux-mips.org>
To: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: Daniel Sanders <daniel.sanders@imgtec.com>,
Scott Egerton <Scott.Egerton@imgtec.com>,
Paul Burton <paul.burton@imgtec.com>,
Markos Chandras <markos.chandras@imgtec.com>,
Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>,
linux-mips@linux-mips.org
Subject: Re: [PATCH] mips: Avoid a form of the .type directive that is not supported by LLVM's Integrated Assembler
Date: Wed, 24 Feb 2016 02:50:58 +0100 [thread overview]
Message-ID: <20160224015058.GA25673@linux-mips.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1602171944410.15885@tp.orcam.me.uk>
On Wed, Feb 17, 2016 at 08:04:31PM +0000, Maciej W. Rozycki wrote:
> If LLVM strives to be GNU toolchain compatible, then this looks like a
> bug in their scanner as generic ELF support in GAS (gas/config/obj-elf.c)
> has this, in `obj_elf_type':
>
> if (*input_line_pointer == ',')
> ++input_line_pointer;
>
> so the comma is entirely optional. I realise this is undocumented, but
> there you go. It must have been there since forever.
It contradicts documentation. The gas manual says:
* Type:: `.type <INT | NAME , TYPE DESCRIPTION>'
And the SGI assembler manual I dug up as ".type name, value". So maybe
gas is too generous here?
Either way, I think the patch is right and I've just applied v2.
Ralf
next prev parent reply other threads:[~2016-02-24 1:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 15:37 [PATCH] mips: Avoid a form of the .type directive that is not supported by LLVM's Integrated Assembler Daniel Sanders
2016-02-17 15:37 ` Daniel Sanders
2016-02-17 20:04 ` Maciej W. Rozycki
2016-02-17 20:04 ` Maciej W. Rozycki
2016-02-19 10:06 ` Daniel Sanders
2016-02-19 10:06 ` Daniel Sanders
2016-02-24 1:50 ` Ralf Baechle [this message]
2016-02-24 12:30 ` Maciej W. Rozycki
2016-02-24 12:30 ` Maciej W. Rozycki
2016-02-24 14:26 ` Daniel Sanders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224015058.GA25673@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Leonid.Yegoshin@imgtec.com \
--cc=Scott.Egerton@imgtec.com \
--cc=daniel.sanders@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@imgtec.com \
--cc=markos.chandras@imgtec.com \
--cc=paul.burton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.