From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 24 Feb 2016 09:02:18 +0000 From: Joel Becker To: Deepa Dinamani Cc: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org, Arnd Bergmann , linux-kernel@vger.kernel.org, stoph Hellwig Subject: Re: [PATCH 4/8] fs: configfs: Replace CURRENT_TIME by current_fs_time() Message-ID: <20160224090218.GJ29804@ZenIV.linux.org.uk> References: <1456154274-30487-1-git-send-email-deepa.kernel@gmail.com> <1456154274-30487-5-git-send-email-deepa.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456154274-30487-5-git-send-email-deepa.kernel@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Acked-by: Joel Becker On Mon, Feb 22, 2016 at 07:17:50AM -0800, Deepa Dinamani wrote: > CURRENT_TIME macro is not appropriate for filesystems as it > doesn't use the right granularity for filesystem timestamps. > Use current_fs_time() instead. > > Signed-off-by: Deepa Dinamani > Cc: Joel Becker > Cc: stoph Hellwig > --- > fs/configfs/inode.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/fs/configfs/inode.c b/fs/configfs/inode.c > index cee087d..5f24ad3 100644 > --- a/fs/configfs/inode.c > +++ b/fs/configfs/inode.c > @@ -75,7 +75,8 @@ int configfs_setattr(struct dentry * dentry, struct iattr * iattr) > sd_iattr->ia_mode = sd->s_mode; > sd_iattr->ia_uid = GLOBAL_ROOT_UID; > sd_iattr->ia_gid = GLOBAL_ROOT_GID; > - sd_iattr->ia_atime = sd_iattr->ia_mtime = sd_iattr->ia_ctime = CURRENT_TIME; > + sd_iattr->ia_atime = sd_iattr->ia_mtime = > + sd_iattr->ia_ctime = current_fs_time(inode->i_sb); > sd->s_iattr = sd_iattr; > } > /* attributes were changed atleast once in past */ > @@ -111,7 +112,8 @@ int configfs_setattr(struct dentry * dentry, struct iattr * iattr) > static inline void set_default_inode_attr(struct inode * inode, umode_t mode) > { > inode->i_mode = mode; > - inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; > + inode->i_atime = inode->i_mtime = > + inode->i_ctime = current_fs_time(inode->i_sb); > } > > static inline void set_inode_attr(struct inode * inode, struct iattr * iattr) > @@ -195,7 +197,7 @@ int configfs_create(struct dentry * dentry, umode_t mode, void (*init)(struct in > return -ENOMEM; > > p_inode = d_inode(dentry->d_parent); > - p_inode->i_mtime = p_inode->i_ctime = CURRENT_TIME; > + p_inode->i_mtime = p_inode->i_ctime = current_fs_time(p_inode->i_sb); > configfs_set_inode_lock_class(sd, inode); > > init(inode); > -- > 1.9.1 > --