From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/3] llistxattr/llistxattr01.c: add new testcase
Date: Wed, 24 Feb 2016 14:38:14 +0100 [thread overview]
Message-ID: <20160224133814.GC8292@rei> (raw)
In-Reply-To: <1455857746-25721-1-git-send-email-yangx.jy@cn.fujitsu.com>
Hi!
> The testcase checks the basic functionality of the llistxattr(2).
> llistxattr(2) retrieves the list of extended attribute names
> associated with the link itself in the filesystem.
I've added tst_require_root() into the test setup, since modifying
attrinbutes in security namespace requires it.
> +static void set_xattr(const char *path, const char *key)
> +{
> + int n;
> +
> + n = lsetxattr(path, key, VALUE, VALUE_SIZE, XATTR_CREATE);
> + if (n == -1) {
> + if (errno == ENOTSUP) {
> + tst_brkm(TCONF, cleanup,
> + "no xattr support in fs or mounted "
> + "without user_xattr option");
> + }
> +
> + if (errno == EEXIST) {
> + tst_brkm(TFAIL, cleanup, "exist attribute %s", key);
> + } else {
> + tst_brkm(TFAIL | TERRNO, cleanup,
> + "lsetxattr() failed");
And changed these two to TBROK since it's more "test broken in setup"
rather than "test assertion failed".
And pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2016-02-24 13:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 9:08 [LTP] [PATCH 1/3] llistxattr/llistxattr01.c: add new testcase Xiao Yang
2016-01-29 9:08 ` [LTP] [PATCH 2/3] llistxattr/llistxattr02.c: " Xiao Yang
2016-02-10 13:41 ` Cyril Hrubis
2016-01-29 9:08 ` [LTP] [PATCH 3/3] llistxattr/llistxattr03.c: " Xiao Yang
2016-02-10 14:12 ` Cyril Hrubis
2016-02-10 14:04 ` [LTP] [PATCH 1/3] llistxattr/llistxattr01.c: " Cyril Hrubis
2016-02-18 10:02 ` Xiao Yang
2016-02-18 12:03 ` Cyril Hrubis
2016-02-19 4:55 ` [LTP] [PATCH v2 " Xiao Yang
2016-02-19 4:55 ` [LTP] [PATCH v2 2/3] llistxattr/llistxattr02.c: " Xiao Yang
2016-02-24 13:54 ` Cyril Hrubis
2016-02-19 4:55 ` [LTP] [PATCH v2 3/3] llistxattr/llistxattr03.c: " Xiao Yang
2016-02-24 14:28 ` Cyril Hrubis
2016-02-25 3:55 ` [LTP] [PATCH v3] " Xiao Yang
2016-02-25 11:21 ` Cyril Hrubis
2016-02-24 13:38 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224133814.GC8292@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.