From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758296AbcBXQlo (ORCPT <rfc822;w@1wt.eu>);
	Wed, 24 Feb 2016 11:41:44 -0500
Received: from mail.skyhub.de ([78.46.96.112]:48028 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758045AbcBXQln (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 24 Feb 2016 11:41:43 -0500
Date: Wed, 24 Feb 2016 17:41:39 +0100
From: Borislav Petkov <bp@alien8.de>
To: Matt Fleming <matt@codeblueprint.co.uk>,
        Andy Lutomirski <luto@amacapital.net>
Cc: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
        Toshi Kani <toshi.kani@hp.com>, Brian Gerst <brgerst@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Luis Rodriguez <mcgrof@suse.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Denys Vlasenko <dvlasenk@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, ricardo.neri@intel.com,
        Hugh Dickins <hughd@google.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [tip:efi/core] x86/mm/pat: Use _PAGE_GLOBAL bit for EFI page
 table mappings
Message-ID: <20160224164139.GF3888@pd.tnic>
References: <1455712566-16727-4-git-send-email-matt@codeblueprint.co.uk>
 <tip-397630150632639b3ca5b4414accd5011c45e276@git.kernel.org>
 <CALCETrW17PWUywMCKWn=KGNLfJQ9kPHXeX2h9sVR47TzyGOJww@mail.gmail.com>
 <1456275002.2781.41.camel@intel.com>
 <CALCETrWUcCRdbY4teQPdv068XH9UDDRLVV3UKzpM=g5k=JGk_A@mail.gmail.com>
 <20160224141046.GA2603@codeblueprint.co.uk>
 <20160224162002.GE3888@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160224162002.GE3888@pd.tnic>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 24, 2016 at 05:20:02PM +0100, Borislav Petkov wrote:
> That's mixed mode. I think you mean the FLUSH_TLB_ALL in efi_call.
> That's EFI on 64-bit but that is mandated by the spec, AFAIR.

Ok, so mfleming set me straight on IRC - that's tip/master I should be
staring at.

In any case, I think we should do __flush_tlb_all() in efi_call_cirt()
just in case, for the simple reason that EFI could be installing some
funky TLB entries which we don't want. I'm not saying it does and it
probably won't but what's stopping it?

Or am I being overly paranoid?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.