From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dennis Dalessandro Subject: Re: [PATCH] Staging: rdma: hfi1: verbs_mcast: fixed a brace coding style issue Date: Wed, 24 Feb 2016 12:08:47 -0500 Message-ID: <20160224170846.GA32144@phlsvsds.ph.intel.com> References: <1456068639-4745-1-git-send-email-Becher.Jannik@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Content-Disposition: inline In-Reply-To: <1456068639-4745-1-git-send-email-Becher.Jannik-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jannik Becher Cc: infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Sun, Feb 21, 2016 at 04:30:39PM +0100, Jannik Becher wrote: >Fixed a coding style issue. > >Signed-off-by: Jannik Becher >--- > drivers/staging/rdma/hfi1/verbs_mcast.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/drivers/staging/rdma/hfi1/verbs_mcast.c b/drivers/staging/rdma/hfi1/verbs_mcast.c >index afc6b4c..c45d4b1 100644 >--- a/drivers/staging/rdma/hfi1/verbs_mcast.c >+++ b/drivers/staging/rdma/hfi1/verbs_mcast.c >@@ -140,11 +140,11 @@ struct hfi1_mcast *hfi1_mcast_find(struct hfi1_ibport *ibp, union ib_gid *mgid) > > ret = memcmp(mgid->raw, mcast->mgid.raw, > sizeof(union ib_gid)); >- if (ret < 0) >+ if (ret < 0) { > n = n->rb_left; >- else if (ret > 0) >+ } else if (ret > 0) { > n = n->rb_right; >- else { >+ } else { > atomic_inc(&mcast->refcount); > spin_unlock_irqrestore(&ibp->lock, flags); > goto bail; >-- Doug, This has been taken care already when I moved the code to rdmavt. Patch is submitted in the midst of my other stuff for 4.6. See: http://www.spinics.net/lists/linux-rdma/msg32802.html -Denny -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758286AbcBXRXT (ORCPT ); Wed, 24 Feb 2016 12:23:19 -0500 Received: from mga11.intel.com ([192.55.52.93]:5490 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758234AbcBXRXR (ORCPT ); Wed, 24 Feb 2016 12:23:17 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,494,1449561600"; d="scan'208";a="54061719" Date: Wed, 24 Feb 2016 12:08:47 -0500 From: Dennis Dalessandro To: Jannik Becher Cc: infinipath@intel.com, linux-rdma@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: rdma: hfi1: verbs_mcast: fixed a brace coding style issue Message-ID: <20160224170846.GA32144@phlsvsds.ph.intel.com> References: <1456068639-4745-1-git-send-email-Becher.Jannik@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1456068639-4745-1-git-send-email-Becher.Jannik@gmail.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 21, 2016 at 04:30:39PM +0100, Jannik Becher wrote: >Fixed a coding style issue. > >Signed-off-by: Jannik Becher >--- > drivers/staging/rdma/hfi1/verbs_mcast.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/drivers/staging/rdma/hfi1/verbs_mcast.c b/drivers/staging/rdma/hfi1/verbs_mcast.c >index afc6b4c..c45d4b1 100644 >--- a/drivers/staging/rdma/hfi1/verbs_mcast.c >+++ b/drivers/staging/rdma/hfi1/verbs_mcast.c >@@ -140,11 +140,11 @@ struct hfi1_mcast *hfi1_mcast_find(struct hfi1_ibport *ibp, union ib_gid *mgid) > > ret = memcmp(mgid->raw, mcast->mgid.raw, > sizeof(union ib_gid)); >- if (ret < 0) >+ if (ret < 0) { > n = n->rb_left; >- else if (ret > 0) >+ } else if (ret > 0) { > n = n->rb_right; >- else { >+ } else { > atomic_inc(&mcast->refcount); > spin_unlock_irqrestore(&ibp->lock, flags); > goto bail; >-- Doug, This has been taken care already when I moved the code to rdmavt. Patch is submitted in the midst of my other stuff for 4.6. See: http://www.spinics.net/lists/linux-rdma/msg32802.html -Denny