Re: [PATCH 02/10] examples/test-cxgbe-filters: add example to test cxgbe fdir support

[Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>]

Hi Bruce,

On Wednesday, February 02/24/16, 2016 at 06:40:56 -0800, Bruce Richardson wrote:
> On Wed, Feb 03, 2016 at 02:02:23PM +0530, Rahul Lakkireddy wrote:
> > Add a new test_cxgbe_filters command line example to test support for
> > Chelsio T5 hardware filtering. Shows how to pass the Chelsio input flow
> > and input masks. Also, shows how to pass extra behavior arguments to
> > rewrite fields in matched filter rules.
> > 
> > Also add documentation and update MAINTAINERS.
> > 
> > Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> > Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>
> 
> Hi,
> 
> for testing NIC functionality, the "testpmd" app is what is used, and it already
> contains support for existing flow director functionality. Should the testing
> functionality not be included there?
> 

We initially thought of adding example by extending flow director in
testpmd itself.  However, based on discussion at [1], we then created
a separate sample app for this considering each vendor would come up
with their own sample app.

[1] http://permalink.gmane.org/gmane.comp.networking.dpdk.devel/31471

> Note: that's not to say we don't need a simple example app as well, for 
> demonstrating how to use flow director, but at minimum for nic features we
> generally need to have testpmd support.
> 
> Can this patchset perhaps be changed to include some testpmd support, and maybe
> have any example apps as a separate set?
> 

If adding example in the existing testpmd sounds more appropriate then,
I will re-submit by updating testpmd instead.

Thanks,
Rahul