All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alison Schofield <amsfield22@gmail.com>
To: daniel.baluta@intel.com
Cc: outreachy-kernel@googlegroups.com
Subject: IIO Coding Task 2 ?
Date: Wed, 24 Feb 2016 11:43:53 -0800	[thread overview]
Message-ID: <20160224194352.GA3122@d830.WORKGROUP> (raw)

Daniel,

I'm working on IIO coding task #2.

In 'auditing IIO device state updates to locking' I believe that
in addition to "Updates to state changes must always take mlock",
any checks of device state must also take mlock.  And that is,
what you are asking us to do in this task.
(iio_buffer_enabled is checking device state, not setting)

Basically, anywhere iio_dev->currentmode is set|checked use mlock.

Right track?

For this task, I'm not clear on why we are doing RFC.  In practice, 
mlock is used very consistently for protecting device state.
Can you clarify the controversial aspect?

Thanks!
alisons


             reply	other threads:[~2016-02-24 19:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 19:43 Alison Schofield [this message]
     [not found] ` <56CEB5B4.5060605@intel.com>
2016-02-25  8:55   ` IIO Coding Task 2 ? Daniel Baluta
2016-02-25 18:26     ` Alison Schofield
2016-03-01  3:47       ` Alison Schofield
2016-03-01  9:43         ` Daniel Baluta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160224194352.GA3122@d830.WORKGROUP \
    --to=amsfield22@gmail.com \
    --cc=daniel.baluta@intel.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.