From: Jonathan Nieder <jrnieder@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org, Jens.Lehmann@web.de, peff@peff.net,
sunshine@sunshineco.com
Subject: Re: [PATCH 3/7] run_processes_parallel: rename parameters for the callbacks
Date: Wed, 24 Feb 2016 17:47:02 -0800 [thread overview]
Message-ID: <20160225014702.GQ28749@google.com> (raw)
In-Reply-To: <1456364525-21190-4-git-send-email-sbeller@google.com>
Stefan Beller wrote:
> +++ b/run-command.h
> @@ -159,7 +159,7 @@ typedef int (*get_next_task_fn)(struct child_process *cp,
> * the negative signal number.
> */
> typedef int (*start_failure_fn)(struct child_process *cp,
> - struct strbuf *err,
> + struct strbuf *out,
> void *pp_cb,
> void *pp_task_cb);
Yay, thank you. The docstrings still refer to err.
Jonathan
next prev parent reply other threads:[~2016-02-25 1:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 1:41 [PATCHv16 0/7] Expose submodule parallelism to the user Stefan Beller
2016-02-25 1:41 ` [PATCH 1/7] run_processes_parallel: treat output of children as byte array Stefan Beller
2016-02-25 1:42 ` [PATCH 2/7] run-command: expose default_{start_failure, task_finished} Stefan Beller
2016-02-25 1:42 ` [PATCH 3/7] run_processes_parallel: rename parameters for the callbacks Stefan Beller
2016-02-25 1:47 ` Jonathan Nieder [this message]
2016-02-25 1:42 ` [PATCH 4/7] run_processes_parallel: correctly terminate callbacks with an LF Stefan Beller
2016-02-25 1:42 ` [PATCH 5/7] git submodule update: have a dedicated helper for cloning Stefan Beller
2016-02-25 1:42 ` [PATCH 6/7] submodule update: expose parallelism to the user Stefan Beller
2016-02-25 1:42 ` [PATCH 7/7] clone: allow an explicit argument for parallel submodule clones Stefan Beller
2016-02-25 1:54 ` [PATCHv16 0/7] Expose submodule parallelism to the user Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225014702.GQ28749@google.com \
--to=jrnieder@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.