From: Al Viro <viro@ZenIV.linux.org.uk>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Sasha Levin <sasha.levin@oracle.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
mingo@kernel.org, peterz@infradead.org
Subject: Re: [PATCH] signals: work around random wakeups in sigsuspend()
Date: Thu, 25 Feb 2016 03:18:52 +0000 [thread overview]
Message-ID: <20160225031852.GV17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20160125190915.GA9362@redhat.com>
On Mon, Jan 25, 2016 at 08:09:15PM +0100, Oleg Nesterov wrote:
> On 01/25, Sasha Levin wrote:
> >
> > A random wakeup can get us out of sigsuspend() without TIF_SIGPENDING
> > being set.
>
> and TIF_RESTORE_SIGMASK is just wrong in this case. I'd say this is the
> bugfix, not work-around ;)
>
> > Avoid that by making sure we were signaled, like sys_pause() does.
> >
> > Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
>
> Acked-by: Oleg Nesterov <oleg@redhat.com>
>
> Thanks Sasha.
Out of curiousity - where did that stray wakeup come from? PTRACE_KILL
used to trigger those, but that got fixed. How does one trigger that
kind of bugs on the current kernels?
next prev parent reply other threads:[~2016-02-25 3:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 15:21 [PATCH] signals: work around random wakeups in sigsuspend() Sasha Levin
2016-01-25 19:09 ` Oleg Nesterov
2016-01-25 19:37 ` Peter Zijlstra
2016-02-25 3:18 ` Al Viro [this message]
2016-02-25 8:11 ` Peter Zijlstra
2016-02-25 17:34 ` Al Viro
2016-01-25 21:32 ` Andrew Morton
2016-01-26 21:10 ` Oleg Nesterov
2016-01-27 8:44 ` Peter Zijlstra
2016-01-27 16:41 ` Oleg Nesterov
2016-01-27 17:54 ` Peter Zijlstra
2016-01-27 18:39 ` Andrew Morton
2016-01-27 21:07 ` Oleg Nesterov
2016-01-27 17:24 ` Sasha Levin
2016-01-26 6:44 ` Ingo Molnar
2016-01-26 15:05 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225031852.GV17997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.