From: Fam Zheng <famz@redhat.com>
To: Stefan Priebe - Profihost AG <s.priebe@profihost.ag>
Cc: Timo Grodzinski <t.grodzinski@profihost.ag>,
John Snow <jsnow@redhat.com>, qemu-devel <qemu-devel@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] drive-backup
Date: Thu, 25 Feb 2016 15:59:49 +0800 [thread overview]
Message-ID: <20160225075949.GC14319@ad.usersys.redhat.com> (raw)
In-Reply-To: <56CEB21C.6020109@profihost.ag>
On Thu, 02/25 08:49, Stefan Priebe - Profihost AG wrote:
>
> Am 22.02.2016 um 23:08 schrieb John Snow:
> >
> >
> > On 02/22/2016 03:21 PM, Stefan Priebe wrote:
> >> Hello,
> >>
> >> is there any chance or hack to work with a bigger cluster size for the
> >> drive backup job?
> >>
> >> See:
> >> http://git.qemu.org/?p=qemu.git;a=blob;f=block/backup.c;h=16105d40b193be9bb40346027bdf58e62b956a96;hb=98d2c6f2cd80afaa2dc10091f5e35a97c181e4f5
> >>
> >>
> >> This is very slow with ceph - may be due to the 64k block size. I would
> >> like to check whether this is faster with cephs native block size of 4mb.
> >>
> >> Greets,
> >> Stefan
> >>
> >
> > It's hardcoded to 64K at the moment, but I am checking in a patch to
> > round up the cluster size to be the bigger of (64k,
> > $target_cluster_size) in order to make sure that incremental backups in
> > particular never copy a fraction of a cluster. As a side-effect, the
> > same round-up will happen for all modes (sync=top,none,full).
> >
> > If QEMU is aware of the target cluster size of 4MB, this would
> > immediately jump the copy-size up to 4MB clusters for you.
> >
> > See: https://lists.nongnu.org/archive/html/qemu-devel/2016-02/msg02839.html
>
> Thanks for your patches and thanks for your great answer. But our
> problem is not the target but the source ;-) The target has a local
> cache and don't care about the cluster size but the source does not.
>
> But it works fine if we change the default cluster size to 4MB. So it
> has point us to the right direction.
Does it mean overriding the copy granularity is what you want to do?
Asking because drive-mirror has a "granularity" parameter for this purpose, if
so it should probably be considered for drive-backup as well.
Fam
next prev parent reply other threads:[~2016-02-25 8:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 20:21 [Qemu-devel] drive-backup Stefan Priebe
2016-02-22 22:08 ` John Snow
2016-02-25 7:49 ` Stefan Priebe - Profihost AG
2016-02-25 7:59 ` Fam Zheng [this message]
2016-02-25 19:53 ` John Snow
2016-02-26 8:56 ` Stefan Priebe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225075949.GC14319@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=s.priebe@profihost.ag \
--cc=t.grodzinski@profihost.ag \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.