From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760345AbcBYMt3 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Feb 2016 07:49:29 -0500
Received: from mail.kernel.org ([198.145.29.136]:49615 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752279AbcBYMt2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Feb 2016 07:49:28 -0500
Date: Thu, 25 Feb 2016 09:49:24 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Namhyung Kim <namhyung@kernel.org>, Li Zefan <lizefan@huawei.com>,
        pi3orama@163.com
Subject: Re: [RFC PATCH 2/2] perf script: Print bpf-output events in 'perf
 script'
Message-ID: <20160225124924.GJ8720@kernel.org>
References: <1456312845-111583-1-git-send-email-wangnan0@huawei.com>
 <1456312845-111583-3-git-send-email-wangnan0@huawei.com>
 <20160224151918.GC8720@kernel.org>
 <56CE7EDF.7030808@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56CE7EDF.7030808@huawei.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Thu, Feb 25, 2016 at 12:11:11PM +0800, Wangnan (F) escreveu:
> 
> 
> On 2016/2/24 23:19, Arnaldo Carvalho de Melo wrote:
> >Em Wed, Feb 24, 2016 at 11:20:45AM +0000, Wang Nan escreveu:
> >>This patch allows 'perf script' output messages from BPF program.
> >>For example, use test_bpf_output_3.c at the end of this commit
> >>message,
> >>
> >>  # ./perf record -e bpf-output/no-inherit,name=evt/ \
> >>                  -e ./test_bpf_output_3.c/map:channel.event=evt/ \
> >>                  usleep 100000
> >Trying to test this with 'perf trace', i.e. to shortcircuit record +
> >analysis:
> >
> >[root@jouet bpf]# perf trace -a --ev bpf-output/no-inherit,name=evt/ --ev ./test_bpf_output_3.c/map:channel.event=evt/ --ev 'perf_bpf_probe:*' usleep 100000
> >Failed to set filter "common_pid != 23954" on event evt with 22 (Invalid argument)
> >
> >Can't we set tracepoint filters on these events?
 
> No we can't. filters can only be set to tracepoint events, but
> bpf-output is a software event.

Gack, should've checked that, I somehow thought that it was a tracepoint
event of some sort.
 
> In addition, you don't need
>   ... --ev 'perf_bpf_probe:*' ...
> 
> because they should be already collected by '--ev ./test_bpf_output_3.c'.

Right, that was me trying to be clever 8-)
 
> You don't see them because the two kprobe events are filtered out by
> BPF program.  See 'return 0' in func.

Thanks for reminding about this part...
 
> Thank you.