From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760484AbcBYMuw (ORCPT ); Thu, 25 Feb 2016 07:50:52 -0500 Received: from mail.kernel.org ([198.145.29.136]:49673 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759934AbcBYMuu (ORCPT ); Thu, 25 Feb 2016 07:50:50 -0500 Date: Thu, 25 Feb 2016 09:50:47 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Li Zefan , pi3orama@163.com Subject: Re: [RFC PATCH 1/5] perf trace: Apply config options in '.perfconfig' Message-ID: <20160225125047.GK8720@kernel.org> References: <1456390315-127562-1-git-send-email-wangnan0@huawei.com> <1456390315-127562-2-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456390315-127562-2-git-send-email-wangnan0@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Feb 25, 2016 at 08:51:51AM +0000, Wang Nan escreveu: > 'perf trace' doesn't read and apply options in ~/.perfconfig. If a BPF > script is passed to 'perf trace --ev' and clang is not in $PATH, > perf trace doesn't compile the script even clang-path is configured in > ~/.perfconfig. > > This patch makes 'perf trace' read and apply default config options > from that file. Right, I wonder if we can't move this initialization to perf's main instead of having to call this for each subcommand... > Signed-off-by: Wang Nan > Cc: Arnaldo Carvalho de Melo > Cc: Jiri Olsa > Cc: Li Zefan > Cc: pi3orama@163.com > --- > tools/perf/builtin-trace.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c > index 20916dd..6c52f3c 100644 > --- a/tools/perf/builtin-trace.c > +++ b/tools/perf/builtin-trace.c > @@ -3108,6 +3108,8 @@ int cmd_trace(int argc, const char **argv, const char *prefix __maybe_unused) > goto out; > } > > + perf_config(perf_default_config, NULL); > + > argc = parse_options_subcommand(argc, argv, trace_options, trace_subcommands, > trace_usage, PARSE_OPT_STOP_AT_NON_OPTION); > > -- > 1.8.3.4