From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH v5 10/20] kthread: Better support freezable kthread workers Date: Thu, 25 Feb 2016 14:01:15 +0100 Message-ID: <20160225130115.GJ6357@twins.programming.kicks-ass.net> References: <1456153030-12400-1-git-send-email-pmladek@suse.com> <1456153030-12400-11-git-send-email-pmladek@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1456153030-12400-11-git-send-email-pmladek-IBi9RG/b67k@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Petr Mladek Cc: Andrew Morton , Oleg Nesterov , Tejun Heo , Ingo Molnar , Steven Rostedt , "Paul E. McKenney" , Josh Triplett , Thomas Gleixner , Linus Torvalds , Jiri Kosina , Borislav Petkov , Michal Hocko , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Vlastimil Babka , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On Mon, Feb 22, 2016 at 03:57:00PM +0100, Petr Mladek wrote: > +enum { > + KTW_FREEZABLE = 1 << 2, /* freeze during suspend */ > +}; Weird value; what was wrong with 1 << 0 ? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f171.google.com (mail-pf0-f171.google.com [209.85.192.171]) by kanga.kvack.org (Postfix) with ESMTP id 37F156B0253 for ; Thu, 25 Feb 2016 08:01:20 -0500 (EST) Received: by mail-pf0-f171.google.com with SMTP id q63so32578176pfb.0 for ; Thu, 25 Feb 2016 05:01:20 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id i3si12410647pap.187.2016.02.25.05.01.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Feb 2016 05:01:19 -0800 (PST) Date: Thu, 25 Feb 2016 14:01:15 +0100 From: Peter Zijlstra Subject: Re: [PATCH v5 10/20] kthread: Better support freezable kthread workers Message-ID: <20160225130115.GJ6357@twins.programming.kicks-ass.net> References: <1456153030-12400-1-git-send-email-pmladek@suse.com> <1456153030-12400-11-git-send-email-pmladek@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456153030-12400-11-git-send-email-pmladek@suse.com> Sender: owner-linux-mm@kvack.org List-ID: To: Petr Mladek Cc: Andrew Morton , Oleg Nesterov , Tejun Heo , Ingo Molnar , Steven Rostedt , "Paul E. McKenney" , Josh Triplett , Thomas Gleixner , Linus Torvalds , Jiri Kosina , Borislav Petkov , Michal Hocko , linux-mm@kvack.org, Vlastimil Babka , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, Feb 22, 2016 at 03:57:00PM +0100, Petr Mladek wrote: > +enum { > + KTW_FREEZABLE = 1 << 2, /* freeze during suspend */ > +}; Weird value; what was wrong with 1 << 0 ? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760504AbcBYNB0 (ORCPT ); Thu, 25 Feb 2016 08:01:26 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:38582 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759749AbcBYNBY (ORCPT ); Thu, 25 Feb 2016 08:01:24 -0500 Date: Thu, 25 Feb 2016 14:01:15 +0100 From: Peter Zijlstra To: Petr Mladek Cc: Andrew Morton , Oleg Nesterov , Tejun Heo , Ingo Molnar , Steven Rostedt , "Paul E. McKenney" , Josh Triplett , Thomas Gleixner , Linus Torvalds , Jiri Kosina , Borislav Petkov , Michal Hocko , linux-mm@kvack.org, Vlastimil Babka , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 10/20] kthread: Better support freezable kthread workers Message-ID: <20160225130115.GJ6357@twins.programming.kicks-ass.net> References: <1456153030-12400-1-git-send-email-pmladek@suse.com> <1456153030-12400-11-git-send-email-pmladek@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456153030-12400-11-git-send-email-pmladek@suse.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 22, 2016 at 03:57:00PM +0100, Petr Mladek wrote: > +enum { > + KTW_FREEZABLE = 1 << 2, /* freeze during suspend */ > +}; Weird value; what was wrong with 1 << 0 ?