From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH] iommu/amd: Apply workaround for ATS write permission check Date: Thu, 25 Feb 2016 16:07:27 +0100 Message-ID: <20160225150727.GD2280@suse.de> References: <1455140881-17041-1-git-send-email-jay@jcornwall.me> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1455140881-17041-1-git-send-email-jay-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Jay Cornwall Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Wed, Feb 10, 2016 at 03:48:01PM -0600, Jay Cornwall wrote: > The AMD Family 15h Models 30h-3Fh (Kaveri) BIOS and Kernel Developer's > Guide omitted part of the BIOS IOMMU L2 register setup specification. > Without this setup the IOMMU L2 does not fully respect write permissions > when handling an ATS translation request. > > The IOMMU L2 will set PTE dirty bit when handling an ATS translation with > write permission request, even when PTE RW bit is clear. This may occur by > direct translation (which would cause a PPR) or by prefetch request from > the ATC. > > This is observed in practice when the IOMMU L2 modifies a PTE which maps a > pagecache page. The ext4 filesystem driver BUGs when asked to writeback > these (non-modified) pages. > > Enable ATS write permission check in the Kaveri IOMMU L2 if BIOS has not. > > Signed-off-by: Jay Cornwall > Cc: # v3.19+ > --- > drivers/iommu/amd_iommu_init.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:42351 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760788AbcBYPHa (ORCPT ); Thu, 25 Feb 2016 10:07:30 -0500 Date: Thu, 25 Feb 2016 16:07:27 +0100 From: Joerg Roedel To: Jay Cornwall Cc: iommu@lists.linux-foundation.org, stable@vger.kernel.org Subject: Re: [PATCH] iommu/amd: Apply workaround for ATS write permission check Message-ID: <20160225150727.GD2280@suse.de> References: <1455140881-17041-1-git-send-email-jay@jcornwall.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455140881-17041-1-git-send-email-jay@jcornwall.me> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Feb 10, 2016 at 03:48:01PM -0600, Jay Cornwall wrote: > The AMD Family 15h Models 30h-3Fh (Kaveri) BIOS and Kernel Developer's > Guide omitted part of the BIOS IOMMU L2 register setup specification. > Without this setup the IOMMU L2 does not fully respect write permissions > when handling an ATS translation request. > > The IOMMU L2 will set PTE dirty bit when handling an ATS translation with > write permission request, even when PTE RW bit is clear. This may occur by > direct translation (which would cause a PPR) or by prefetch request from > the ATC. > > This is observed in practice when the IOMMU L2 modifies a PTE which maps a > pagecache page. The ext4 filesystem driver BUGs when asked to writeback > these (non-modified) pages. > > Enable ATS write permission check in the Kaveri IOMMU L2 if BIOS has not. > > Signed-off-by: Jay Cornwall > Cc: # v3.19+ > --- > drivers/iommu/amd_iommu_init.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) Applied, thanks.