From: Bjorn Helgaas <helgaas@kernel.org>
To: Paul Burton <paul.burton@imgtec.com>
Cc: Rob Herring <robh@kernel.org>,
Linux-MIPS <linux-mips@linux-mips.org>,
Bharat Kumar Gogada <bharatku@xilinx.com>,
Michal Simek <michal.simek@xilinx.com>,
Ravikiran Gummaluri <rgummal@xilinx.com>,
Ley Foon Tan <lftan@altera.com>, Arnd Bergmann <arnd@arndb.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
Scott Branden <sbranden@broadcom.com>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Duc Dang <dhdang@apm.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Gabriele Paoloni <gabriele.paoloni@huawei.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Ray Jui <rjui@broadcom.com>, Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH v3 6/6] PCI: xilinx: Allow build on MIPS platforms
Date: Thu, 25 Feb 2016 09:43:26 -0600 [thread overview]
Message-ID: <20160225154326.GE8120@localhost> (raw)
In-Reply-To: <20160204175325.GB31145@NP-P-BURTON>
On Thu, Feb 04, 2016 at 05:53:25PM +0000, Paul Burton wrote:
> On Thu, Feb 04, 2016 at 11:46:28AM -0600, Rob Herring wrote:
> > On Thu, Feb 4, 2016 at 10:10 AM, Paul Burton <paul.burton@imgtec.com> wrote:
> > > Allow the xilinx-pcie driver to be built on MIPS platforms. This will be
> > > used on the MIPS Boston board.
> > >
> > > Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> > >
> > > ---
> > >
> > > Changes in v3:
> > > - Split out from Boston patchset.
> > >
> > > Changes in v2: None
> > >
> > > drivers/pci/host/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> > > index 75a6054..0aee193 100644
> > > --- a/drivers/pci/host/Kconfig
> > > +++ b/drivers/pci/host/Kconfig
> > > @@ -81,7 +81,7 @@ config PCI_KEYSTONE
> > >
> > > config PCIE_XILINX
> > > bool "Xilinx AXI PCIe host bridge support"
> > > - depends on ARCH_ZYNQ
> > > + depends on ARCH_ZYNQ || MIPS
> >
> > Why don't you just remove the dependency? Then it gets better build coverage.
> >
> > Rob
>
> That seems like a call best made by whomever has to maintain this - if
> that's the preferred way to go I'm fine with it.
I'm in favor of removing the dependency if possible. I guess Michal
would be the person to ack that.
Right now (in my current "next" branch),
drivers/pci/host/pcie-xilinx.c uses struct hw_pci, which is only
defined by arm.
Bjorn
next prev parent reply other threads:[~2016-02-25 15:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 16:10 [PATCH v3 0/6] Xilinx AXI PCIe Host Bridge driver fixes Paul Burton
2016-02-04 16:10 ` Paul Burton
2016-02-04 16:10 ` Paul Burton
2016-02-04 16:10 ` [PATCH v3 1/6] PCI: xilinx: Keep references to both IRQ domains Paul Burton
2016-02-04 16:10 ` Paul Burton
2016-02-04 16:10 ` Paul Burton
2016-02-04 16:10 ` [PATCH v3 2/6] PCI: xilinx: Unify INTx & MSI interrupt FIFO decode Paul Burton
2016-02-04 16:10 ` Paul Burton
2016-02-04 16:10 ` Paul Burton
2016-02-11 5:42 ` Bharat Kumar Gogada
2016-02-11 5:42 ` Bharat Kumar Gogada
2016-02-11 5:50 ` Bharat Kumar Gogada
2016-02-11 5:50 ` Bharat Kumar Gogada
2016-02-04 16:10 ` [PATCH v3 3/6] PCI: xilinx: Always clear interrupt decode register Paul Burton
2016-02-04 16:10 ` Paul Burton
2016-02-04 16:10 ` Paul Burton
2016-02-04 16:10 ` [PATCH v3 4/6] PCI: xilinx: Clear interrupt FIFO during probe Paul Burton
2016-02-04 16:10 ` Paul Burton
2016-02-04 16:10 ` Paul Burton
2016-02-11 6:20 ` Bharat Kumar Gogada
2016-02-11 6:20 ` Bharat Kumar Gogada
2016-02-04 16:10 ` [PATCH v3 5/6] PCI: xilinx: Fix INTX irq dispatch Paul Burton
2016-02-04 16:10 ` Paul Burton
2016-02-04 16:10 ` Paul Burton
2016-02-04 16:10 ` [PATCH v3 6/6] PCI: xilinx: Allow build on MIPS platforms Paul Burton
2016-02-04 16:10 ` Paul Burton
2016-02-04 17:46 ` Rob Herring
2016-02-04 17:53 ` Paul Burton
2016-02-25 15:43 ` Bjorn Helgaas [this message]
2016-02-26 7:49 ` Michal Simek
2016-02-25 15:59 ` [PATCH v3 0/6] Xilinx AXI PCIe Host Bridge driver fixes Bjorn Helgaas
2016-02-25 15:59 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225154326.GE8120@localhost \
--to=helgaas@kernel.org \
--cc=arnd@arndb.de \
--cc=bharatku@xilinx.com \
--cc=bhelgaas@google.com \
--cc=dhdang@apm.com \
--cc=gabriele.paoloni@huawei.com \
--cc=geert+renesas@glider.be \
--cc=hauke@hauke-m.de \
--cc=lftan@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=michal.simek@xilinx.com \
--cc=paul.burton@imgtec.com \
--cc=phil.edworthy@renesas.com \
--cc=rgummal@xilinx.com \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.