From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id w197si141446wmw.3.2016.02.25.08.56.01 for ; Thu, 25 Feb 2016 08:56:01 -0800 (PST) Date: Thu, 25 Feb 2016 17:54:49 +0100 From: Alexandre Belloni To: Joshua Henderson Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alessandro Zummo , rtc-linux@googlegroups.com Subject: [rtc-linux] Re: [PATCH v2 2/2] rtc: rtc-pic32: Add PIC32 real time clock driver Message-ID: <20160225165449.GH12073@piout.net> References: <1455905390-3491-2-git-send-email-joshua.henderson@microchip.com> <20160224222555.GA12073@piout.net> <56CF2A9B.5080005@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <56CF2A9B.5080005@microchip.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 25/02/2016 at 09:23:55 -0700, Joshua Henderson wrote : > On 02/24/2016 03:25 PM, Alexandre Belloni wrote: > > Hi, > > > > On 19/02/2016 at 11:09:45 -0700, Joshua Henderson wrote : > >> +static int pic32_rtc_gettime(struct device *dev, struct rtc_time *rtc_tm) > >> +{ > >> + struct pic32_rtc_dev *pdata = dev_get_drvdata(dev); > >> + void __iomem *base = pdata->reg_base; > >> + unsigned int tries = 0; > >> + > >> + clk_enable(pdata->clk); > >> + > >> + do { > >> + rtc_tm->tm_hour = readb(base + PIC32_RTCHOUR); > >> + rtc_tm->tm_min = readb(base + PIC32_RTCMIN); > >> + rtc_tm->tm_mon = readb(base + PIC32_RTCMON); > >> + rtc_tm->tm_mday = readb(base + PIC32_RTCDAY); > >> + rtc_tm->tm_year = readb(base + PIC32_RTCYEAR); > >> + rtc_tm->tm_sec = readb(base + PIC32_RTCSEC); > >> + > >> + /* > >> + * The only way to work out whether the system was mid-update > >> + * when we read it is to check the second counter, and if it > >> + * is zero, then we re-try the entire read. > >> + */ > >> + tries = 1; > >> + } while (rtc_tm->tm_sec == 0 && tries < 2); > >> + > > > > This doesn't seem right. It will wait up to a second as tries will > > always be less than 2, this is probably not what you want. > > Dang good catch. When fixed, it will work as expected: > > # hwclock > tries 1 > Sun Oct 17 19:23:59 2010 0.000000 seconds > # hwclock > tries 1 > tries 2 > Sun Oct 17 19:24:00 2010 0.000000 seconds > # hwclock > tries 1 > Sun Oct 17 19:24:01 2010 0.000000 seconds > Sure, just send v3, I'll apply it right away ;) -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v2 2/2] rtc: rtc-pic32: Add PIC32 real time clock driver Date: Thu, 25 Feb 2016 17:54:49 +0100 Message-ID: <20160225165449.GH12073@piout.net> References: <1455905390-3491-2-git-send-email-joshua.henderson@microchip.com> <20160224222555.GA12073@piout.net> <56CF2A9B.5080005@microchip.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <56CF2A9B.5080005@microchip.com> Sender: linux-kernel-owner@vger.kernel.org To: Joshua Henderson Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alessandro Zummo , rtc-linux@googlegroups.com List-Id: devicetree@vger.kernel.org On 25/02/2016 at 09:23:55 -0700, Joshua Henderson wrote : > On 02/24/2016 03:25 PM, Alexandre Belloni wrote: > > Hi, > > > > On 19/02/2016 at 11:09:45 -0700, Joshua Henderson wrote : > >> +static int pic32_rtc_gettime(struct device *dev, struct rtc_time *rtc_tm) > >> +{ > >> + struct pic32_rtc_dev *pdata = dev_get_drvdata(dev); > >> + void __iomem *base = pdata->reg_base; > >> + unsigned int tries = 0; > >> + > >> + clk_enable(pdata->clk); > >> + > >> + do { > >> + rtc_tm->tm_hour = readb(base + PIC32_RTCHOUR); > >> + rtc_tm->tm_min = readb(base + PIC32_RTCMIN); > >> + rtc_tm->tm_mon = readb(base + PIC32_RTCMON); > >> + rtc_tm->tm_mday = readb(base + PIC32_RTCDAY); > >> + rtc_tm->tm_year = readb(base + PIC32_RTCYEAR); > >> + rtc_tm->tm_sec = readb(base + PIC32_RTCSEC); > >> + > >> + /* > >> + * The only way to work out whether the system was mid-update > >> + * when we read it is to check the second counter, and if it > >> + * is zero, then we re-try the entire read. > >> + */ > >> + tries = 1; > >> + } while (rtc_tm->tm_sec == 0 && tries < 2); > >> + > > > > This doesn't seem right. It will wait up to a second as tries will > > always be less than 2, this is probably not what you want. > > Dang good catch. When fixed, it will work as expected: > > # hwclock > tries 1 > Sun Oct 17 19:23:59 2010 0.000000 seconds > # hwclock > tries 1 > tries 2 > Sun Oct 17 19:24:00 2010 0.000000 seconds > # hwclock > tries 1 > Sun Oct 17 19:24:01 2010 0.000000 seconds > Sure, just send v3, I'll apply it right away ;) -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com