Re: [PATCH] Weston 1.9: Add Virtual keyboard patch

[Denys Dmytriyenko <denys@ti.com>]

Quick question - is it Weston issue or Qt5 issue? Also, do you plan on 
submitting the fix upstream (to either Weston or Qt5 communities) and 
setting/updating Upstream-Status: field in the patch?

-- 
Denys


On Thu, Feb 25, 2016 at 02:34:42PM -0500, Eric Ruei wrote:
> Signed-off-by: Eric Ruei <e-ruei1@ti.com>
> ---
>  ...-Fix-virtual-keyboard-display-issue-for-Q.patch | 40 ++++++++++++++++++++++
>  .../recipes-graphics/wayland/weston_1.9.0.bbappend |  3 +-
>  2 files changed, 42 insertions(+), 1 deletion(-)
>  create mode 100644 meta-arago-distro/recipes-graphics/wayland/weston/0003-Weston1.9.0-Fix-virtual-keyboard-display-issue-for-Q.patch
> 
> diff --git a/meta-arago-distro/recipes-graphics/wayland/weston/0003-Weston1.9.0-Fix-virtual-keyboard-display-issue-for-Q.patch b/meta-arago-distro/recipes-graphics/wayland/weston/0003-Weston1.9.0-Fix-virtual-keyboard-display-issue-for-Q.patch
> new file mode 100644
> index 0000000..576b37e
> --- /dev/null
> +++ b/meta-arago-distro/recipes-graphics/wayland/weston/0003-Weston1.9.0-Fix-virtual-keyboard-display-issue-for-Q.patch
> @@ -0,0 +1,40 @@
> +From 7d2f4a97306707fb29e743bf66a827e661aa5615 Mon Sep 17 00:00:00 2001
> +From: Eric Ruei <e-ruei1@ti.com>
> +Date: Tue, 23 Feb 2016 18:26:57 -0500
> +Subject: [PATCH 3/3] Weston1.9.0: Fix virtual keyboard display issue for QT5
> + application
> +
> +The virtual keyboard does pop up as expected, however, it will never hide
> +even when the application is terminated. This problem is due to the order
> +of the text APIs( text_input_activate and test_input_show_input_panel) are
> +invoked in QT5 and a potential bug of the API implementation. The virtual
> +keyboard works as expected if the test_input_show_input_panel() is invoked
> +prior to the test_input_activate() as most of the weston sample applications
> +do. However, the problem will show up if that order is reversed and the reason
> +why is that the current_panel is not set in this case and hence this panel
> +cannot be hidden.
> +
> +It is required to set the current_panel to the text_input when the input_panel
> +becomes visible at the first time.
> +
> +
> +Signed-off-by: Eric Ruei <e-ruei1@ti.com>
> +---
> + src/text-backend.c | 1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/src/text-backend.c b/src/text-backend.c
> +index cd6c4d99..ba60949 100644
> +--- a/src/text-backend.c
> ++++ b/src/text-backend.c
> +@@ -338,6 +338,7 @@ text_input_show_input_panel(struct wl_client *client,
> + 			       text_input->surface);
> + 		wl_signal_emit(&ec->update_input_panel_signal,
> + 			       &text_input->cursor_rectangle);
> ++		text_input->manager->current_panel = text_input;
> + 	}
> + }
> + 
> +-- 
> +1.9.1
> +
> diff --git a/meta-arago-distro/recipes-graphics/wayland/weston_1.9.0.bbappend b/meta-arago-distro/recipes-graphics/wayland/weston_1.9.0.bbappend
> index a51f134..99b6d07 100644
> --- a/meta-arago-distro/recipes-graphics/wayland/weston_1.9.0.bbappend
> +++ b/meta-arago-distro/recipes-graphics/wayland/weston_1.9.0.bbappend
> @@ -2,7 +2,7 @@
>  PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor WESTON_NATIVE_BACKEND="fbdev-backend.so",--disable-fbdev-compositor,udev mtdev"
>  PACKAGECONFIG[kms] = "--enable-drm-compositor,--disable-drm-compositor,drm udev libgbm mtdev"
>  
> -PR_append = "-arago3"
> +PR_append = "-arago4"
>  
>  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>  
> @@ -11,5 +11,6 @@ RDEPENDS_${PN} += "weston-conf"
>  SRC_URI += " \
>  	file://0001-weston1.9.0-Enabling-DRM-backend-with-multiple-displ.patch \
>  	file://0002-Weston1.9.0-Allow-visual_id-to-be-0.patch \
> +	file://0003-Weston1.9.0-Fix-virtual-keyboard-display-issue-for-Q.patch \
>  	file://0001-udev-seat-restrict-udev-enumeration-to-card0.patch \
>  "
> -- 
> 1.9.1
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago