All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] staging: lustre: lustre: obdclass: Remove unneeded NULL check
@ 2016-02-21 19:50 Janani Ravichandran
  2016-02-26  6:16 ` [Outreachy kernel] " Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Janani Ravichandran @ 2016-02-21 19:50 UTC (permalink / raw)
  To: outreachy-kernel

Remove unneeded NULL check before debugfs_remove_recursive.
Generated-by: scripts/coccinelle/free/ifnullfree.cocci

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
---
 drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
index 1913f3e..2045621 100644
--- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
+++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
@@ -454,8 +454,7 @@ out:
 
 int class_procfs_clean(void)
 {
-	if (debugfs_lustre_root != NULL)
-		debugfs_remove_recursive(debugfs_lustre_root);
+	debugfs_remove_recursive(debugfs_lustre_root);
 
 	debugfs_lustre_root = NULL;
 
-- 
2.5.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Outreachy kernel] [PATCH v2] staging: lustre: lustre: obdclass: Remove unneeded NULL check
  2016-02-21 19:50 [PATCH v2] staging: lustre: lustre: obdclass: Remove unneeded NULL check Janani Ravichandran
@ 2016-02-26  6:16 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-02-26  6:16 UTC (permalink / raw)
  To: Janani Ravichandran; +Cc: outreachy-kernel

On Sun, Feb 21, 2016 at 02:50:37PM -0500, Janani Ravichandran wrote:
> Remove unneeded NULL check before debugfs_remove_recursive.
> Generated-by: scripts/coccinelle/free/ifnullfree.cocci
> 
> Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
> ---
>  drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> index 1913f3e..2045621 100644
> --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> @@ -454,8 +454,7 @@ out:
>  
>  int class_procfs_clean(void)
>  {
> -	if (debugfs_lustre_root != NULL)
> -		debugfs_remove_recursive(debugfs_lustre_root);
> +	debugfs_remove_recursive(debugfs_lustre_root);
>  
>  	debugfs_lustre_root = NULL;
>  

Doesn't apply to the tree :(


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-26  6:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-21 19:50 [PATCH v2] staging: lustre: lustre: obdclass: Remove unneeded NULL check Janani Ravichandran
2016-02-26  6:16 ` [Outreachy kernel] " Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.