Re: [Outreachy kernel] [PATCH] Staging: lustre: Use list_for_each_entry instead of list_for_each

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Feb 25, 2016 at 11:47:17PM +0530, Bhumika Goyal wrote:
> Use list_for_each_entry instead of list_for_each and list_entry as it
> simplifies the code. Done using coccinelle:
> 
> @@
> type T,T2;
> identifier I1,I2;
> expression e1,e2;
> iterator name list_for_each_entry;
> iterator name list_for_each;
> @@
> 
> - T *I1;
> ...
> - list_for_each(I1,e1)
> + list_for_each_entry(I2,e1,e2)
> {
> ...when!=T *I1;
> - I2=list_entry(I1,T2,e2);
> ...
> }
> ...when!=I2;
> 
> @@
> type T,T2,T3;
> identifier I1,I2,I3;
> expression e1,e2;
> @@
> 
> - T *I1;
> + T3 *I3;
> ...
> - list_for_each(I1,e1)
> + list_for_each_entry(I3,e1,e2)
> {
> ...when!=T *I1;
> - T3 *I3=list_entry(I1,T2,e2);
> ...
> }
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  .../staging/lustre/lustre/obdecho/echo_client.c    |  4 +--
>  drivers/staging/lustre/lustre/ptlrpc/client.c      | 31 +++++-----------------
>  2 files changed, 8 insertions(+), 27 deletions(-)

ALWAYS test build your patches, otherwise you will end up with grumpy
maintainers complaining you didn't test build your patches and they
broke the build.

Hint, this broke the build.  Not good :(