[Buildroot] [Buildroot PATCH Selinux v10 04/11] linux-pam: selinux host dependencies

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Niranjan,

On Fri, 26 Feb 2016 12:28:39 +0530, Niranjan Reddy wrote:

> > > +     if [ -d $(TARGET_DIR)/etc/pam.d.orig ]; then \
> > > +             cp -a $(TARGET_DIR)/etc/pam.d/*
> > $(TARGET_DIR)/etc/pam.d.orig/; \
> > > +             rm -rf $(TARGET_DIR)/etc/pam.d/; \
> > > +             mv $(TARGET_DIR)/etc/pam.d.orig/ $(TARGET_DIR)/etc/pam.d/;
> > \
> > > +     fi;
> >
> > ; not needed
> >
> 
>   Are you sure you want me to remove these ? If I remove  " ; \"  it gives
> me compilation error.  when I see
>   build-root manual in section 17.15.2 , if condition statements are ended
> with semicolon. Please let me know.

I'm not asking you to remove all ; \, but only to remove the ones that
separate independent commands, since they are useless. I.e you are
currently doing:

1	if [ ... ] ; then \
2		cp -a ..... ; \
3	fi ; \
4	cd $(TARGET_DIR) .... ; \
5	if [ ... ] ; then \
6		cp -a .... ; \
7	fi ; \
8	$(INSTALL) -D ...

The \ or ; \ is needed on lines 1, 2, 4 and 5. But not on lines 3 and 7.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com