From: Stephen Boyd <sboyd@codeaurora.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Michael Turquette <mturquette@baylibre.com>,
Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: Ignore disabled DT clock providers
Date: Fri, 26 Feb 2016 09:42:14 -0800 [thread overview]
Message-ID: <20160226174214.GR28849@codeaurora.org> (raw)
In-Reply-To: <1456502071-13516-1-git-send-email-geert+renesas@glider.be>
On 02/26, Geert Uytterhoeven wrote:
> of_clk_init() uses for_each_matching_node_and_match() to find clock
> providers, which returns all matching device nodes, whether they are
> enabled or not. Hence clock providers that are disabled explicitly in DT
> using e.g.
>
> "status = "disabled";
>
> are still activated.
>
> Add a check to ignore device nodes that are not enabled, like
> of_irq_init() does.
>
> Reported-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
Applied to clk-next
Too bad there isn't a for_each_available_matching_node_and_match()
macro to make this all one line. It would be a mouthful though.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2016-02-26 17:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 15:54 [PATCH] clk: Ignore disabled DT clock providers Geert Uytterhoeven
2016-02-26 17:42 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160226174214.GR28849@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=ramesh.shanmugasundaram@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.