All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: Eric Ruei <e-ruei1@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [PATCH] Re-enable dual camera demo on AM4
Date: Fri, 26 Feb 2016 14:20:01 -0500	[thread overview]
Message-ID: <20160226192001.GX29852@edge> (raw)
In-Reply-To: <1456505620-48160-1-git-send-email-e-ruei1@ti.com>

Eric,

The patch looks good and the description is informative, but the commit log is 
not following the guidelines I linked yesterday. Instead of this:

Subject: [PATCH] Re-enable dual camera demo on AM4

It should be:

Subject: [PATCH] dual-camera-demo: re-enable on AM4 to run outside of Weston

-- 
Denys


On Fri, Feb 26, 2016 at 11:53:40AM -0500, Eric Ruei wrote:
> The dual camera demo stopped working when Wayland/DRM-based graphics support
> was introduced on AM4 and therefore this demo was disabled. This demo does not
> work with Wayland/DRM-based graphics system because it invokes DRM APIs to
> demonstrate DRM mode setings and overlay operations and those operations
> are denied because there should be only one DRM master.
> 
> The simple solution is to update the demo script to run this QT5-based demo
> program over linuxfb platform and therefore there is not another DRM master
> running.
> 
> Signed-off-by: Eric Ruei <e-ruei1@ti.com>
> ---
> V2 Changes: Remove DOS <CR> from dual_camera_qt5.sh
> 
>  .../dual-camera-demo/dual-camera-demo/dual_camera_qt5.sh         | 9 +++++----
>  .../recipes-multimedia/dual-camera-demo/dual-camera-demo_1.0.bb  | 2 +-
>  2 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/meta-arago-extras/recipes-multimedia/dual-camera-demo/dual-camera-demo/dual_camera_qt5.sh b/meta-arago-extras/recipes-multimedia/dual-camera-demo/dual-camera-demo/dual_camera_qt5.sh
> index 9bf560b..4802337 100644
> --- a/meta-arago-extras/recipes-multimedia/dual-camera-demo/dual-camera-demo/dual_camera_qt5.sh
> +++ b/meta-arago-extras/recipes-multimedia/dual-camera-demo/dual-camera-demo/dual_camera_qt5.sh
> @@ -1,12 +1,13 @@
>  #!/bin/bash
>  
> -/etc/init.d/matrix-gui-2.0 stop
> +/etc/init.d/weston stop
> +sleep 1
>  
>  echo 0 > /sys/class/graphics/fbcon/cursor_blink
>  
> -dual_camera
> +dual_camera -platform linuxfb
>  
>  echo 1 > /sys/class/graphics/fbcon/cursor_blink
>  
> -/etc/init.d/matrix-gui-2.0 start
> -
> +/etc/init.d/weston start
> +sleep 1
> diff --git a/meta-arago-extras/recipes-multimedia/dual-camera-demo/dual-camera-demo_1.0.bb b/meta-arago-extras/recipes-multimedia/dual-camera-demo/dual-camera-demo_1.0.bb
> index 43bf00d..1b1a146 100644
> --- a/meta-arago-extras/recipes-multimedia/dual-camera-demo/dual-camera-demo_1.0.bb
> +++ b/meta-arago-extras/recipes-multimedia/dual-camera-demo/dual-camera-demo_1.0.bb
> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=c7ca707704d3354a64feeb4f19f52eb5"
>  DEPENDS += "libdrm"
>  require recipes-core/matrix/matrix-gui-paths.inc
>  
> -PR = "r12"
> +PR = "r13"
>  
>  BRANCH = "drm"
>  SRCREV = "3be10676149c5f6e0ef1660d6b1ee4b9165dd993"
> -- 
> 1.9.1
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


  reply	other threads:[~2016-02-26 19:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26 16:53 [PATCH] Re-enable dual camera demo on AM4 Eric Ruei
2016-02-26 19:20 ` Denys Dmytriyenko [this message]
2016-02-26 19:46   ` Ruei, Eric
2016-02-26 19:53     ` Denys Dmytriyenko
  -- strict thread matches above, loose matches on Subject: below --
2016-02-25 19:18 Eric Ruei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160226192001.GX29852@edge \
    --to=denys@ti.com \
    --cc=e-ruei1@ti.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.