All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Alan <alan@linux.intel.com>
Cc: dbaryshkov@gmail.com, dwmw2@infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/2] goldfish: Enable ACPI-based enumeration for goldfish battery
Date: Fri, 26 Feb 2016 21:03:26 +0100	[thread overview]
Message-ID: <20160226200326.GA19840@earth> (raw)
In-Reply-To: <20160226184541.2962.40016.stgit@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

Hi Alan,

On Fri, Feb 26, 2016 at 06:45:50PM +0000, Alan wrote:
> From: Yu Ning <yu.ning@intel.com>
> 
> Besides adding ACPI bindings to the goldfish battery driver, modify the
> ACPI driver to inform it that goldfish battery is a platform device.
> The latter step is necessary with kernel 3.16 or newer.

I don't understand the second part of the commit message. The patch
only seems to add ACPI bindings to the goldfish battery driver. Did
you forget to add something?

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-02-26 20:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26 18:45 [PATCH 1/2] power: goldfish_battery: add devicetree bindings Alan
2016-02-26 18:45 ` [PATCH 2/2] goldfish: Enable ACPI-based enumeration for goldfish battery Alan
2016-02-26 20:03   ` Sebastian Reichel [this message]
2016-03-01 23:27     ` Alan Cox
2016-03-03 14:19 ` [PATCH 1/2] power: goldfish_battery: add devicetree bindings Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160226200326.GA19840@earth \
    --to=sre@kernel.org \
    --cc=alan@linux.intel.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.