From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755670AbcBZXxf (ORCPT <rfc822;w@1wt.eu>);
	Fri, 26 Feb 2016 18:53:35 -0500
Received: from one.firstfloor.org ([193.170.194.197]:45089 "EHLO
	one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754279AbcBZXxe (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 26 Feb 2016 18:53:34 -0500
Date: Sat, 27 Feb 2016 00:53:31 +0100
From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>, acme@kernel.org, jolsa@kernel.org,
        linux-kernel@vger.kernel.org, eranian@google.com,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/6] perf, tools, stat: Support metrics in
 --per-core/socket mode
Message-ID: <20160226235331.GK5083@two.firstfloor.org>
References: <1455749045-18098-1-git-send-email-andi@firstfloor.org>
 <1455749045-18098-4-git-send-email-andi@firstfloor.org>
 <20160221172201.GE10701@krava.homerouter.cpe>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160221172201.GE10701@krava.homerouter.cpe>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +
> >  static void print_aggr(char *prefix)
> >  {
> >  	FILE *output = stat_config.output;
> > @@ -982,6 +1024,8 @@ static void print_aggr(char *prefix)
> >  	if (!(aggr_map || aggr_get_id))
> >  		return;
> >  
> > +	aggr_update_shadow();
> 
> this should be called from perf_stat_process_counter,
> not from display function

I tried it, but the function needs a lot of stuff (aggr_map,
evsel_list) that only exists in builtin-stat. Passing all
that around is quite complicated and intrusive.

I left it alone for now.

-Andi