All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe MacDonald <Joe_MacDonald@mentor.com>
To: Zhenbo Gao <zhenbo.gao@windriver.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] postfix: permission of /var/spool/mail seems incorrect
Date: Fri, 26 Feb 2016 20:48:47 -0500	[thread overview]
Message-ID: <20160227014847.GC6310@mentor.com> (raw)
In-Reply-To: <1453712086-16685-2-git-send-email-zhenbo.gao@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

[[oe] [PATCH] postfix: permission of /var/spool/mail seems incorrect] On 16.01.25 (Mon 16:54) Zhenbo Gao wrote:

> See the following output:
> root@qemu0:~# rpm -qlv postfix | grep /var/spool/mail
> drwxr-sr-x 2 postfix nogroup 0 Sep 8 08:46 /var/spool/mail
> The permission of /var/spool/mail "r-s" seems strange as it
> belongs to nogroup, modify it to 0755 as to the normal case.
> 
> Signed-off-by: Zhenbo Gao <zhenbo.gao@windriver.com>
> ---
>  meta-networking/recipes-daemons/postfix/postfix.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-daemons/postfix/postfix.inc b/meta-networking/recipes-daemons/postfix/postfix.inc
> index dc652d7..378310a 100644
> --- a/meta-networking/recipes-daemons/postfix/postfix.inc
> +++ b/meta-networking/recipes-daemons/postfix/postfix.inc
> @@ -162,7 +162,7 @@ do_install () {
>      install -m 770 -d ${D}${localstatedir}/spool/postfix
>      chown postfix:postfix ${D}${localstatedir}/spool/postfix
>  
> -    install -m 2755 -d ${D}${localstatedir}/spool/mail
> +    install -m 0755 -d ${D}${localstatedir}/spool/mail

While this may stop errors from happening (and I'm not sure it will)
this doesn't seem like the right thing to do.  Consider, for example:

   http://wiki2.dovecot.org/MailLocation/mbox

You almost certainly want the sgid bit set on /var/*/mail.  If there's
an error here, my guess it that the mode should be 2775 not 2755.  If
you'd like to confirm that, cool, otherwise I'll have a look when I get
a chance.

Thanks,
-J.

>      chown postfix:nogroup ${D}${localstatedir}/spool/mail
>      install -m 0755 -d ${D}${localstatedir}/lib/postfix
>      chown postfix:nogroup ${D}${localstatedir}/lib/postfix
> -- 
> 1.9.1
> 
-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

  reply	other threads:[~2016-02-27  1:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25  8:54 [meta-networking] postfix: permission of /var/spool/mail seems incorrect Zhenbo Gao
2016-01-25  8:54 ` [PATCH] " Zhenbo Gao
2016-02-27  1:48   ` Joe MacDonald [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-11-18  7:41 [meta-networking] " Zhenbo Gao
2015-11-18  7:41 ` [PATCH] " Zhenbo Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160227014847.GC6310@mentor.com \
    --to=joe_macdonald@mentor.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=zhenbo.gao@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.