From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 6/7] blk-mq: enable polling support by default Date: Sat, 27 Feb 2016 09:56:48 +0100 Message-ID: <20160227085648.GA4255@lst.de> References: <1456160876-14560-1-git-send-email-hch@lst.de> <1456160876-14560-7-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jeff Moyer Cc: Christoph Hellwig , viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org, axboe-b10kYP2dOMg@public.gmane.org, milosz-B5zB6C1i6pkAvxtiuMwx3w@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On Fri, Feb 26, 2016 at 03:44:30PM -0500, Jeff Moyer wrote: > Hi, Christoph, > > Christoph Hellwig writes: > > > Now that applications need to explicitly ask for polling we can enable it > > by default in blk-mq drivers. > > I don't think this is a good idea. I'd just enable it in nvme and the > micron driver for now. I think my wording was a bit unclear - the flag to enable polling is enabled everywhere. You still need to implement the poll blk_mq operation, which currently only NVMe implements. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:56406 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755918AbcB0I4v (ORCPT ); Sat, 27 Feb 2016 03:56:51 -0500 Date: Sat, 27 Feb 2016 09:56:48 +0100 From: Christoph Hellwig To: Jeff Moyer Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, axboe@fb.com, milosz@adfin.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 6/7] blk-mq: enable polling support by default Message-ID: <20160227085648.GA4255@lst.de> References: <1456160876-14560-1-git-send-email-hch@lst.de> <1456160876-14560-7-git-send-email-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Feb 26, 2016 at 03:44:30PM -0500, Jeff Moyer wrote: > Hi, Christoph, > > Christoph Hellwig writes: > > > Now that applications need to explicitly ask for polling we can enable it > > by default in blk-mq drivers. > > I don't think this is a good idea. I'd just enable it in nvme and the > micron driver for now. I think my wording was a bit unclear - the flag to enable polling is enabled everywhere. You still need to implement the poll blk_mq operation, which currently only NVMe implements.