From: Borislav Petkov <bp@suse.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Alexander Kuleshov <kuleshovmail@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Joerg Roedel <jroedel@suse.de>,
Dave Young <dyoung@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <bhe@redhat.com>, Mark Salter <msalter@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7] x86/setup: get ramdisk parameters only once
Date: Sat, 27 Feb 2016 13:44:29 +0100 [thread overview]
Message-ID: <20160227124429.GA5337@pd.tnic> (raw)
In-Reply-To: <20160227115546.GC16200@gmail.com>
On Sat, Feb 27, 2016 at 12:55:46PM +0100, Ingo Molnar wrote:
> So I find it highly annoying that this review feedback was done by Boris, but not
> implemented in v8 :-(
And I missed it when going over v8. :-(
FWIW, since recently I get the impression that people don't take review
feedback seriously. Starting to think, why even bother...
> I'd much have preferred fewer iterations and more careful implementation, which
> would have resulted in much less time wasted on the reviewer side...
Agreed.
> Anyway, to stop this trainwreck I've fixed this (and a few other small details)
> and applied the patch, but I'd also like to point out that from now on I'll stop
> accepting trivial patches from serial trivial patches contributors that are not
> part of some larger, more substantial work...
Good idea. ACK.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
prev parent reply other threads:[~2016-02-27 12:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 7:31 [PATCH v7] x86/setup: get ramdisk parameters only once Alexander Kuleshov
2016-02-26 8:37 ` Borislav Petkov
2016-02-27 11:55 ` Ingo Molnar
2016-02-27 12:44 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160227124429.GA5337@pd.tnic \
--to=bp@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=jroedel@suse.de \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=msalter@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.