All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Andy Lutomirski <tipbot@zytor.com>, Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Pratyush Anand <panand@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH tip/x86/asm] uprobes: __create_xol_area() must nullify xol_mapping.fault
Date: Sat, 27 Feb 2016 23:11:28 +0100	[thread overview]
Message-ID: <20160227221128.GA29565@redhat.com> (raw)

As Jiri pointed out, the recent commit f872f5400cc0 "mm: Add a
vm_special_mapping.fault() method" breaks uprobes. __create_xol_area()
doesn't initialize the new ->fault() method and this obviously leads to
kernel crash when the application tries to execute the probed insn after
bp hit.

We probably want to add uprobes_special_mapping_fault(), this allows to
turn xol_area->xol_mapping into a single instance of vm_special_mapping.
But we need a simple fix, so lets change __create_xol() to nullify the
new member as Jiri suggests.

Reported-by: Jiri Olsa <jolsa@redhat.com>
Suggested-by: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
 kernel/events/uprobes.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 0167679..5f6ce93 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -1178,6 +1178,7 @@ static struct xol_area *__create_xol_area(unsigned long vaddr)
 		goto free_area;
 
 	area->xol_mapping.name = "[uprobes]";
+	area->xol_mapping.fault = NULL;
 	area->xol_mapping.pages = area->pages;
 	area->pages[0] = alloc_page(GFP_HIGHUSER);
 	if (!area->pages[0])
-- 
2.5.0

             reply	other threads:[~2016-02-27 22:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-27 22:11 Oleg Nesterov [this message]
2016-02-29 11:02 ` [tip:x86/asm] uprobes: __create_xol_area() must nullify xol_mapping.fault tip-bot for Oleg Nesterov
2016-02-29 11:42 ` [PATCH tip/x86/asm] " Peter Zijlstra
2016-02-29 15:51   ` Oleg Nesterov
2016-02-29 16:14     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160227221128.GA29565@redhat.com \
    --to=oleg@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=panand@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tipbot@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.