From: Tejun Heo <tj@kernel.org>
To: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 0/4] staging: most: hdm-dim2: Use devm_* functions
Date: Sun, 28 Feb 2016 08:44:36 -0500 [thread overview]
Message-ID: <20160228134436.GS3965@htj.duckdns.org> (raw)
In-Reply-To: <cover.1455803765.git.amitoj1606@gmail.com>
On Thu, Feb 18, 2016 at 08:11:16PM +0530, Amitoj Kaur Chawla wrote:
> Devm_ functions allocate memory that is released when a driver
> detaches. Replace kzalloc, ioremap and request_irq with their devm_*
> counterparts in the probe function of a platform device which were
> originally freed in the remove function.
>
> Also, unnecessary labels have been removed, an unnecessary
> platform_set_drvdata has been removed as well as switching from pr_err
> to dev_err.
>
> Amitoj Kaur Chawla (4):
> staging: most: hdm-dim2: Replace kzalloc with devm_kzalloc
> staging: most: hdm-dim2: Switch to devm_ioremap_resource()
> staging: most: hdm-dim2: Replace request_irq with devm_request_irq
> staging: most: hdm-dim2: Replace pr_err with dev_err
For the patchset,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2016-02-28 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 14:41 [PATCH 0/4] staging: most: hdm-dim2: Use devm_* functions Amitoj Kaur Chawla
2016-02-18 14:41 ` [PATCH 1/4] staging: most: hdm-dim2: Replace kzalloc with devm_kzalloc Amitoj Kaur Chawla
2016-02-18 14:41 ` [PATCH 2/4] staging: most: hdm-dim2: Switch to devm_ioremap_resource() Amitoj Kaur Chawla
2016-02-18 14:42 ` [PATCH 3/4] staging: most: hdm-dim2: Replace request_irq with devm_request_irq Amitoj Kaur Chawla
2016-02-18 14:42 ` [PATCH 4/4] staging: most: hdm-dim2: Replace pr_err with dev_err Amitoj Kaur Chawla
2016-02-28 13:44 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160228134436.GS3965@htj.duckdns.org \
--to=tj@kernel.org \
--cc=amitoj1606@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.