From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Romain Izard <romain.izard.pro@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] serial: mctrl_gpio: Add missing module license
Date: Mon, 29 Feb 2016 09:49:40 +0100 [thread overview]
Message-ID: <20160229084940.GF2613@pengutronix.de> (raw)
In-Reply-To: <1456239294-28342-1-git-send-email-romain.izard.pro@gmail.com>
Hello Romain,
On Tue, Feb 23, 2016 at 03:54:54PM +0100, Romain Izard wrote:
> As the mctrl_gpio driver can be built as a module, it needs to have its
> license specified with MODULE_LICENSE. Otherwise, it cannot access
> required symbols exported through EXPORT_SYMBOL_GPL.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> ---
> drivers/tty/serial/serial_mctrl_gpio.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
> index 226ad23b136c..02147361eaa9 100644
> --- a/drivers/tty/serial/serial_mctrl_gpio.c
> +++ b/drivers/tty/serial/serial_mctrl_gpio.c
> @@ -20,6 +20,7 @@
> #include <linux/gpio/consumer.h>
> #include <linux/termios.h>
> #include <linux/serial_core.h>
> +#include <linux/module.h>
>
> #include "serial_mctrl_gpio.h"
>
> @@ -249,3 +250,5 @@ void mctrl_gpio_disable_ms(struct mctrl_gpios *gpios)
> }
> }
> EXPORT_SYMBOL_GPL(mctrl_gpio_disable_ms);
> +
> +MODULE_LICENSE("GPL");
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2016-02-29 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 14:54 [PATCH v1] serial: mctrl_gpio: Add missing module license Romain Izard
2016-02-23 15:21 ` Fabio Estevam
2016-02-23 16:05 ` Romain Izard
2016-02-29 8:49 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160229084940.GF2613@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=romain.izard.pro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.