From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752331AbcB2JLM (ORCPT <rfc822;w@1wt.eu>);
	Mon, 29 Feb 2016 04:11:12 -0500
Received: from mail-wm0-f44.google.com ([74.125.82.44]:33192 "EHLO
	mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751593AbcB2JLH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 29 Feb 2016 04:11:07 -0500
Date: Mon, 29 Feb 2016 10:11:02 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
        Sasha Levin <sasha.levin@oracle.com>
Cc: aryabinin@virtuozzo.com, krinkin.m.u@gmail.com, mingo@elte.hu,
        peterz@infradead.org, linux-kernel@vger.kernel.org,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: +
 kernel-locking-lockdepc-make-lockdep-initialize-itself-on-demand.patch added
 to -mm tree
Message-ID: <20160229091102.GA8361@gmail.com>
References: <56b11d2d.vVw1kB2la7Y+70xF%akpm@linux-foundation.org>
 <20160203074430.GA32652@gmail.com>
 <20160203085111.fc3f2631.akpm@linux-foundation.org>
 <20160209111228.GA32615@gmail.com>
 <20160209121732.7713af6a1e244e1af00324de@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20160209121732.7713af6a1e244e1af00324de@linux-foundation.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Andrew Morton <akpm@linux-foundation.org> wrote:

> On Tue, 9 Feb 2016 12:12:29 +0100 Ingo Molnar <mingo@kernel.org> wrote:
> 
> > > The conceptual problem is that if some piece of code does spin_lock_init() or 
> > > DEFINE_SPINLOCK(), that lock isn't necessarily initialized yet.
> > 
> > The conceptual problem is that the data structures are not build time initialized 
> > - but the hlist conversion patch solves that problem nicely!
> > 
> > So I'm a happy camper.
> 
> OK, so the below has been in -next for nearly a week, no issues.  We
> should get this into 4.5 to fix the CONFIG_UBSAN_ALIGNMENT issue.

So I think this patch broke liblockdep:

triton:~/tip/tools/lib/lockdep> 

In file included from lockdep.c:2:0:
../../../kernel/locking/lockdep.c: In function ‘look_up_lock_class’:
../../../kernel/locking/lockdep.c:722:2: warning: implicit declaration of function ‘hlist_for_each_entry_rcu’ [-Wimplicit-function-declaration]
  hlist_for_each_entry_rcu(class, hash_head, hash_entry) {

...

Thanks,

	Ingo