From: Christoph Hellwig <hch@infradead.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Christoph Hellwig <hch@lst.de>,
Kinglong Mee <kinglongmee@gmail.com>,
"J. Bruce Fields" <bfields@redhat.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
Trond Myklebust <trond.myklebust@primarydata.com>
Subject: Re: nfsd: supports read buffer from multiples pages
Date: Mon, 29 Feb 2016 01:49:54 -0800 [thread overview]
Message-ID: <20160229094954.GA23406@infradead.org> (raw)
In-Reply-To: <20160202142948.GA14068@fieldses.org>
On Tue, Feb 02, 2016 at 09:29:48AM -0500, J. Bruce Fields wrote:
> OK. And what's the failure mode if the layoutcommit fails? I guess the
> client returns the layout and redoes IO through the MDS. For a rare
> failure maybe that's not so terrible.
>
> So I guess the right thing to do is take Kinglong's patch for now.
Yes, it would be great to take it.
> After that, it wouldn't be that hard for nfsd4_block_proc_layoutcommit
> to decode from an array of pages. But does the iomaps array end up
> being just as big?
The block layout extents are rather bloated, so it will be significantly
smaller.
prev parent reply other threads:[~2016-02-29 9:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 12:50 nfsd: supports read buffer from multiples pages Kinglong Mee
2016-02-01 18:38 ` J. Bruce Fields
2016-02-01 18:48 ` J. Bruce Fields
2016-02-02 0:54 ` Kinglong Mee
2016-02-02 9:20 ` Christoph Hellwig
2016-02-02 14:29 ` J. Bruce Fields
2016-02-29 9:49 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160229094954.GA23406@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=hch@lst.de \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.