All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagig@dev.mellanox.co.il>
Cc: Christoph Hellwig <hch@lst.de>,
	linux-rdma@vger.kernel.org, swise@opengridcomputing.com,
	sagig@mellanox.com, target-devel@vger.kernel.org
Subject: Re: [PATCH 02/13] IB/core: allow passing mapping an offset into the SG in ib_map_mr_sg
Date: Mon, 29 Feb 2016 12:15:57 +0100	[thread overview]
Message-ID: <20160229111557.GA11499@lst.de> (raw)
In-Reply-To: <56D30AF7.1060205@dev.mellanox.co.il>

> This looks wrong...
>
> The SG offset should not be taken into account in the address
> translation vector that is given to the HW. The sg_offset needs to
> be accounted in the mr->iova:
>
> mr->iova = sg_dma_address(&sgl[0]) + sg_offset;
>
> I think the page mappings should stay as the are.

I looked at this in a bit more detail, and I think we need both.

For PAGE_SIZE or smaller SG entries you're correct, and we don't
need the offset for dma_addr.  But it doesn't harm either.  But
for lager SG entries we need it to calculate the correct
base address.

  parent reply	other threads:[~2016-02-29 11:15 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-27 18:10 RFC: a first draft of a generic RDMA READ/WRITE API Christoph Hellwig
2016-02-27 18:10 ` [PATCH 04/13] IB/core: refactor ib_create_qp Christoph Hellwig
2016-02-27 18:10 ` [PATCH 06/13] IB/core: add a need_inval flag to struct ib_mr Christoph Hellwig
2016-02-28 15:10   ` Sagi Grimberg
2016-02-28 16:05     ` Christoph Hellwig
2016-02-27 18:10 ` [PATCH 11/13] IB/isert: the kill ->isert_cmd back pointer in the struct iser_tx_desc Christoph Hellwig
     [not found] ` <1456596631-19418-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-27 18:10   ` [PATCH 01/13] IB/cma: pass the port number to ib_create_qp Christoph Hellwig
2016-02-27 18:10   ` [PATCH 02/13] IB/core: allow passing mapping an offset into the SG in ib_map_mr_sg Christoph Hellwig
     [not found]     ` <1456596631-19418-3-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-28 14:57       ` Sagi Grimberg
2016-02-28 16:20         ` Christoph Hellwig
2016-02-28 17:50           ` Sagi Grimberg
     [not found]             ` <56D33356.1020707-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-02-29 22:22               ` Steve Wise
2016-02-29 11:15         ` Christoph Hellwig [this message]
     [not found]           ` <20160229111557.GA11499-jcswGhMUV9g@public.gmane.org>
2016-02-29 11:35             ` Sagi Grimberg
2016-02-29 11:56               ` Christoph Hellwig
2016-02-29 12:08                 ` Sagi Grimberg
2016-02-27 18:10   ` [PATCH 03/13] IB/core: add a helper to check for READ WITH INVALIDATE support Christoph Hellwig
2016-02-27 18:10   ` [PATCH 05/13] IB/core: add a simple MR pool Christoph Hellwig
2016-03-02  2:48     ` Parav Pandit
2016-03-02  9:15       ` Christoph Hellwig
2016-03-02 15:22         ` Bart Van Assche
     [not found]           ` <56D70543.1000506-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-03-03  8:30             ` Christoph Hellwig
2016-02-27 18:10   ` [PATCH 07/13] IB/core: generic RDMA READ/WRITE API Christoph Hellwig
2016-02-28 15:05     ` Sagi Grimberg
2016-02-27 18:10   ` [PATCH 08/13] IB/isert: properly type the login buffer Christoph Hellwig
2016-02-27 18:10   ` [PATCH 09/13] IB/isert: convert to new CQ API Christoph Hellwig
2016-02-27 18:10   ` [PATCH 10/13] IB/isert: kill struct isert_rdma_wr Christoph Hellwig
2016-02-27 18:10   ` [PATCH 12/13] IB/core: add a MR pool for signature MRs Christoph Hellwig
2016-02-27 18:10 ` [PATCH 13/13] IB/isert: RW API WIP Christoph Hellwig
2016-02-28 13:57   ` Sagi Grimberg
2016-02-28 16:04     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160229111557.GA11499@lst.de \
    --to=hch@lst.de \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sagig@dev.mellanox.co.il \
    --cc=sagig@mellanox.com \
    --cc=swise@opengridcomputing.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.