From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: re: drm/amdgpu: Don't hang in amdgpu_flip_work_func on disabled crtc. Date: Mon, 29 Feb 2016 23:10:07 +0300 Message-ID: <20160229201007.GA32069@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by gabe.freedesktop.org (Postfix) with ESMTPS id A055F6E365 for ; Mon, 29 Feb 2016 20:10:21 +0000 (UTC) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: mario.kleiner.de@gmail.com Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGVsbG8gTWFyaW8gS2xlaW5lciwKClRoZSBwYXRjaCBlMWQwOWRjMGNjYzY6ICJkcm0vYW1kZ3B1 OiBEb24ndCBoYW5nIGluCmFtZGdwdV9mbGlwX3dvcmtfZnVuYyBvbiBkaXNhYmxlZCBjcnRjLiIg ZnJvbSBGZWIgMTksIDIwMTYsIGxlYWRzIHRvCnRoZSBmb2xsb3dpbmcgc3RhdGljIGNoZWNrZXIg d2FybmluZzoKCmRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kaXNwbGF5LmM6MTI3 IGFtZGdwdV9mbGlwX3dvcmtfZnVuYygpCXdhcm46IHNob3VsZCB0aGlzIGJlICdyZXBjbnQgPT0g LTEnCmRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kaXNwbGF5LmM6MTM2IGFtZGdw dV9mbGlwX3dvcmtfZnVuYygpIGVycm9yOiBkb3VibGUgdW5sb2NrICdzcGluX2xvY2s6JmNydGMt PmRldi0+ZXZlbnRfbG9jaycKZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rpc3Bs YXkuYzoxMzYgYW1kZ3B1X2ZsaXBfd29ya19mdW5jKCkgZXJyb3I6IGRvdWJsZSB1bmxvY2sgJ2ly cXNhdmU6ZmxhZ3MnCgoKZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rpc3BsYXku YwogICAgNjQgIHN0YXRpYyB2b2lkIGFtZGdwdV9mbGlwX3dvcmtfZnVuYyhzdHJ1Y3Qgd29ya19z dHJ1Y3QgKl9fd29yaykKICAgIDY1ICB7CiAgICA2NiAgICAgICAgICBzdHJ1Y3QgYW1kZ3B1X2Zs aXBfd29yayAqd29yayA9CiAgICA2NyAgICAgICAgICAgICAgICAgIGNvbnRhaW5lcl9vZihfX3dv cmssIHN0cnVjdCBhbWRncHVfZmxpcF93b3JrLCBmbGlwX3dvcmspOwogICAgNjggICAgICAgICAg c3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYgPSB3b3JrLT5hZGV2OwogICAgNjkgICAgICAgICAg c3RydWN0IGFtZGdwdV9jcnRjICphbWRncHVDcnRjID0gYWRldi0+bW9kZV9pbmZvLmNydGNzW3dv cmstPmNydGNfaWRdOwogICAgNzAgIAogICAgNzEgICAgICAgICAgc3RydWN0IGRybV9jcnRjICpj cnRjID0gJmFtZGdwdUNydGMtPmJhc2U7CiAgICA3MiAgICAgICAgICB1bnNpZ25lZCBsb25nIGZs YWdzOwogICAgNzMgICAgICAgICAgdW5zaWduZWQgaSwgcmVwY250ID0gNDsKICAgIDc0ICAgICAg ICAgIGludCB2cG9zLCBocG9zLCBzdGF0LCBtaW5fdWRlbGF5ID0gMDsKICAgIDc1ICAgICAgICAg IHN0cnVjdCBkcm1fdmJsYW5rX2NydGMgKnZibGFuayA9ICZjcnRjLT5kZXYtPnZibGFua1t3b3Jr LT5jcnRjX2lkXTsKICAgIDc2ICAKICAgIDc3ICAgICAgICAgIGlmIChhbWRncHVfZmxpcF9oYW5k bGVfZmVuY2Uod29yaywgJndvcmstPmV4Y2wpKQogICAgNzggICAgICAgICAgICAgICAgICByZXR1 cm47CiAgICA3OSAgCiAgICA4MCAgICAgICAgICBmb3IgKGkgPSAwOyBpIDwgd29yay0+c2hhcmVk X2NvdW50OyArK2kpCiAgICA4MSAgICAgICAgICAgICAgICAgIGlmIChhbWRncHVfZmxpcF9oYW5k bGVfZmVuY2Uod29yaywgJndvcmstPnNoYXJlZFtpXSkpCiAgICA4MiAgICAgICAgICAgICAgICAg ICAgICAgICAgcmV0dXJuOwogICAgODMgIAogICAgODQgICAgICAgICAgLyogV2UgYm9ycm93IHRo ZSBldmVudCBzcGluIGxvY2sgZm9yIHByb3RlY3RpbmcgZmxpcF9zdGF0dXMgKi8KICAgIDg1ICAg ICAgICAgIHNwaW5fbG9ja19pcnFzYXZlKCZjcnRjLT5kZXYtPmV2ZW50X2xvY2ssIGZsYWdzKTsK ICAgIDg2ICAKICAgIDg3ICAgICAgICAgIC8qIElmIHRoaXMgaGFwcGVucyB0byBleGVjdXRlIHdp dGhpbiB0aGUgInZpcnR1YWxseSBleHRlbmRlZCIgdmJsYW5rCiAgICA4OCAgICAgICAgICAgKiBp bnRlcnZhbCBiZWZvcmUgdGhlIHN0YXJ0IG9mIHRoZSByZWFsIHZibGFuayBpbnRlcnZhbCB0aGVu IGl0IG5lZWRzCiAgICA4OSAgICAgICAgICAgKiB0byBkZWxheSBwcm9ncmFtbWluZyB0aGUgbW1p byBmbGlwIHVudGlsIHRoZSByZWFsIHZibGFuayBpcyBlbnRlcmVkLgogICAgOTAgICAgICAgICAg ICogVGhpcyBwcmV2ZW50cyBjb21wbGV0aW5nIGEgZmxpcCB0b28gZWFybHkgZHVlIHRvIHRoZSB3 YXkgd2UgZnVkZ2UKICAgIDkxICAgICAgICAgICAqIG91ciB2YmxhbmsgY291bnRlciBhbmQgdmJs YW5rIHRpbWVzdGFtcHMgaW4gb3JkZXIgdG8gd29yayBhcm91bmQgdGhlCiAgICA5MiAgICAgICAg ICAgKiBwcm9ibGVtIHRoYXQgdGhlIGh3IGZpcmVzIHZibGFuayBpbnRlcnJ1cHRzIGJlZm9yZSBh Y3R1YWwgc3RhcnQgb2YKICAgIDkzICAgICAgICAgICAqIHZibGFuayAod2hlbiBsaW5lIGJ1ZmZl ciByZWZpbGxpbmcgaXMgZG9uZSBmb3IgYSBmcmFtZSkuIEl0CiAgICA5NCAgICAgICAgICAgKiBj b21wbGVtZW50cyB0aGUgZnVkZ2luZyBsb2dpYyBpbiBhbWRncHVfZ2V0X2NydGNfc2Nhbm91dHBv cygpIGZvcgogICAgOTUgICAgICAgICAgICogdGltZXN0YW1waW5nIGFuZCBhbWRncHVfZ2V0X3Zi bGFua19jb3VudGVyX2ttcygpIGZvciB2YmxhbmsgY291bnRzLgogICAgOTYgICAgICAgICAgICoK ICAgIDk3ICAgICAgICAgICAqIEluIHByYWN0aWNlIHRoaXMgd29uJ3QgZXhlY3V0ZSB2ZXJ5IG9m dGVuIHVubGVzcyBvbiB2ZXJ5IGZhc3QKICAgIDk4ICAgICAgICAgICAqIG1hY2hpbmVzIGJlY2F1 c2UgdGhlIHRpbWUgd2luZG93IGZvciB0aGlzIHRvIGhhcHBlbiBpcyB2ZXJ5IHNtYWxsLgogICAg OTkgICAgICAgICAgICovCiAgIDEwMCAgICAgICAgICB3aGlsZSAoYW1kZ3B1Q3J0Yy0+ZW5hYmxl ZCAmJiByZXBjbnQtLSkgewogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgXl5eXl5eXl4KRXhpc3RzIHRoZSBsb29wIHdpdGggc3Bpbl9sb2NrIGhlbGQgYW5kIHJl cGNudCA9PSAtMS4KCgogICAxMDEgICAgICAgICAgICAgICAgICAvKiBHRVRfRElTVEFOQ0VfVE9f VkJMQU5LU1RBUlQgcmV0dXJucyBkaXN0YW5jZSB0byByZWFsIHZibGFuawogICAxMDIgICAgICAg ICAgICAgICAgICAgKiBzdGFydCBpbiBocG9zLCBhbmQgdG8gdGhlICJmdWRnZWQgZWFybGllciIg dmJsYW5rIHN0YXJ0IGluCiAgIDEwMyAgICAgICAgICAgICAgICAgICAqIHZwb3MuCiAgIDEwNCAg ICAgICAgICAgICAgICAgICAqLwogICAxMDUgICAgICAgICAgICAgICAgICBzdGF0ID0gYW1kZ3B1 X2dldF9jcnRjX3NjYW5vdXRwb3MoYWRldi0+ZGRldiwgd29yay0+Y3J0Y19pZCwKICAgMTA2ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdFVF9ESVNU QU5DRV9UT19WQkxBTktTVEFSVCwKICAgMTA3ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICZ2cG9zLCAmaHBvcywgTlVMTCwgTlVMTCwKICAgMTA4ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZjcnRjLT5o d21vZGUpOwogICAxMDkgIAogICAxMTAgICAgICAgICAgICAgICAgICBpZiAoKHN0YXQgJiAoRFJN X1NDQU5PVVRQT1NfVkFMSUQgfCBEUk1fU0NBTk9VVFBPU19BQ0NVUkFURSkpICE9CiAgIDExMSAg ICAgICAgICAgICAgICAgICAgICAoRFJNX1NDQU5PVVRQT1NfVkFMSUQgfCBEUk1fU0NBTk9VVFBP U19BQ0NVUkFURSkgfHwKICAgMTEyICAgICAgICAgICAgICAgICAgICAgICEodnBvcyA+PSAwICYm IGhwb3MgPD0gMCkpCiAgIDExMyAgICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgIDEx NCAgCiAgIDExNSAgICAgICAgICAgICAgICAgIC8qIFNsZWVwIGF0IGxlYXN0IHVudGlsIGVzdGlt YXRlZCByZWFsIHN0YXJ0IG9mIGh3IHZibGFuayAqLwogICAxMTYgICAgICAgICAgICAgICAgICBz cGluX3VubG9ja19pcnFyZXN0b3JlKCZjcnRjLT5kZXYtPmV2ZW50X2xvY2ssIGZsYWdzKTsKICAg MTE3ICAgICAgICAgICAgICAgICAgbWluX3VkZWxheSA9ICgtaHBvcyArIDEpICogbWF4KHZibGFu ay0+bGluZWR1cl9ucyAvIDEwMDAsIDUpOwogICAxMTggICAgICAgICAgICAgICAgICBpZiAobWlu X3VkZWxheSA+IHZibGFuay0+ZnJhbWVkdXJfbnMgLyAyMDAwKSB7CiAgIDExOSAgICAgICAgICAg ICAgICAgICAgICAgICAgLyogRG9uJ3Qgd2FpdCByaWRpY3Vsb3VzbHkgbG9uZyAtIHNvbWV0aGlu ZyBpcyB3cm9uZyAqLwogICAxMjAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlcGNudCA9IDA7 CgpFeGl0IHdpdGggc3Bpbl9sb2NrIHJlbGVhc2VkIGFuZCByZXBjbnQgPT0gMC4KCiAgIDEyMSAg ICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgIDEyMiAgICAgICAgICAgICAgICAgIH0K ICAgMTIzICAgICAgICAgICAgICAgICAgdXNsZWVwX3JhbmdlKG1pbl91ZGVsYXksIDIgKiBtaW5f dWRlbGF5KTsKICAgMTI0ICAgICAgICAgICAgICAgICAgc3Bpbl9sb2NrX2lycXNhdmUoJmNydGMt PmRldi0+ZXZlbnRfbG9jaywgZmxhZ3MpOwogICAxMjUgICAgICAgICAgfTsKICAgMTI2ICAKICAg MTI3ICAgICAgICAgIGlmICghcmVwY250KQogICAgICAgICAgICAgICAgICAgICBeXl5eXl4KQXNz dW1lcyBleGl0IHdpdGggemVyby4KCiAgIDEyOCAgICAgICAgICAgICAgICAgIERSTV9ERUJVR19E UklWRVIoIkRlbGF5IHByb2JsZW0gb24gY3J0YyAlZDogbWluX3VkZWxheSAlZCwgIgogICAxMjkg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJmcmFtZWR1ciAlZCwgbGluZWR1ciAl ZCwgc3RhdCAlZCwgdnBvcyAlZCwgIgogICAxMzAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICJocG9zICVkXG4iLCB3b3JrLT5jcnRjX2lkLCBtaW5fdWRlbGF5LAogICAxMzEgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZibGFuay0+ZnJhbWVkdXJfbnMgLyAxMDAw LAogICAxMzIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZibGFuay0+bGluZWR1 cl9ucyAvIDEwMDAsIHN0YXQsIHZwb3MsIGhwb3MpOwogICAxMzMgIAogICAxMzQgICAgICAgICAg Lyogc2V0IHRoZSBmbGlwIHN0YXR1cyAqLwogICAxMzUgICAgICAgICAgYW1kZ3B1Q3J0Yy0+cGZs aXBfc3RhdHVzID0gQU1ER1BVX0ZMSVBfU1VCTUlUVEVEOwogICAxMzYgICAgICAgICAgc3Bpbl91 bmxvY2tfaXJxcmVzdG9yZSgmY3J0Yy0+ZGV2LT5ldmVudF9sb2NrLCBmbGFncyk7CgpBc3N1bWVz IGxvY2sgaGVsZC4KCiAgIDEzNyAgCiAgIDEzOCAgICAgICAgICAvKiBEbyB0aGUgZmxpcCAobW1p bykgKi8KICAgMTM5ICAgICAgICAgIGFkZXYtPm1vZGVfaW5mby5mdW5jcy0+cGFnZV9mbGlwKGFk ZXYsIHdvcmstPmNydGNfaWQsIHdvcmstPmJhc2UpOwogICAxNDAgIH0KCnJlZ2FyZHMsCmRhbiBj YXJwZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==