All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Vincent Abriou <vincent.abriou@st.com>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	Fabien Dessenne <fabien.dessenne@st.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/2] drm/sti: support of interlaced content with Bottom Field
Date: Mon, 29 Feb 2016 22:41:30 +0200	[thread overview]
Message-ID: <20160229204130.GD15993@intel.com> (raw)
In-Reply-To: <1455269165-1564-1-git-send-email-vincent.abriou@st.com>

On Fri, Feb 12, 2016 at 10:26:03AM +0100, Vincent Abriou wrote:
> Interlaced video can have different scan order:
> Top Field First or Bottom Field First
> 
> In case of video with interlaced content, this information should be
> propagated from the userland to the DRM kernel driver that will process the
> deinterlacing starting with the top or the bottom field first.
> That's why we introduce this new flag definition DRM_MODE_FB_BFF (Bottom Field
> First) that should be used jointly with the already existing
> DRM_MODE_FB_INTERLACED flag incase of interlaced video with Bottom Field First
> scan order should be processed.

The way I envisioned this long ago is that we would specify the
bff/tff at flip time. In fact we already have the
DRM_MODE_PRESENT_TOP_FIELD/DRM_MODE_PRESENT_BOTTOM_FIELD flags for
setplane. When doing bob deinterlacing these would choose the field
we're going to present, and when doing interlaced scanout these would
choose tff vs. bff. But that approach does fall short with atomic when
you want to flip multiple planes at once.

One problem I see with making this part of the FB is that if you already
missed your original deadline for the first field, and you want to
actually present the second field instead, you're forced to create
another fb. So a plane property might be a bit more flexible. And the
same way as the setplane flags we could then share the properties for
bob deinterlacing field selection as well. There's no way to do bob
deinterlacing with fb flags, unless you create a separate fb for each
field.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-02-29 20:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-12  9:26 [PATCH 0/2] drm/sti: support of interlaced content with Bottom Field Vincent Abriou
2016-02-12  9:26 ` [PATCH 1/2] drm: Add DRM_MODE_FB_BFF flag definition Vincent Abriou
2016-02-26 10:33   ` Vincent ABRIOU
2016-02-29 15:32     ` Daniel Vetter
2016-02-29 16:16       ` Vincent ABRIOU
2016-02-29 16:37         ` Daniel Vetter
2016-02-12  9:26 ` [PATCH 2/2] drm/sti: support interlaced top / bottom field first Vincent Abriou
2016-02-29 20:41 ` Ville Syrjälä [this message]
2016-03-03 10:03   ` [PATCH 0/2] drm/sti: support of interlaced content with Bottom Field Fabien DESSENNE
2016-03-03 11:28     ` Ville Syrjälä
2016-03-03 13:28       ` Fabien DESSENNE
2016-03-03 13:33         ` Ville Syrjälä
2016-03-03 14:40           ` Fabien DESSENNE
2016-03-03 15:34             ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160229204130.GD15993@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabien.dessenne@st.com \
    --cc=vincent.abriou@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.