From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH v2] drm/i915: Add missing NULL check before calling initial_watermarks Date: Mon, 29 Feb 2016 13:06:26 -0800 Message-ID: <20160229210626.GD4175@intel.com> References: <1456773635-23362-1-git-send-email-imre.deak@intel.com> <1456776633-3401-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id B85466E375 for ; Mon, 29 Feb 2016 21:06:26 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1456776633-3401-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBGZWIgMjksIDIwMTYgYXQgMTA6MTA6MzNQTSArMDIwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IE5vdCBhbGwgcGxhdGZvcm1zIHNldCB0aGlzIGNhbGxiYWNrLCBzbyBOVUxMIGNoZWNrIGl0 IGJlZm9yZSBjYWxsaW5nIGl0Lgo+IAo+IHYyOgo+IC0gQ2FsbCBpbnRlbF91cGRhdGVfd2F0ZXJt YXJrcygpIG9uIEhTVysgd2hlcmUgdGhlIGNhbGxiYWNrIGlzIG5vdCBzZXQuCj4gICAoTWF0dCkK PiAKPiBDQzogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiBGaXhlczog Y29tbWl0IGVkNGE2YTdjICgiZHJtL2k5MTU6IEFkZCB0d28tc3RhZ2UgSUxLLXN0eWxlIHdhdGVy bWFyayBwcm9ncmFtbWluZyAodjExKSIpCj4gU2lnbmVkLW9mZi1ieTogSW1yZSBEZWFrIDxpbXJl LmRlYWtAaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5yb3Bl ckBpbnRlbC5jb20+CgpUZWNobmljYWxseSB0aGUgY2hhbmdlIGluIGlyb25sYWtlX2NydGNfZW5h YmxlKCkgc2hvdWxkbid0IGJlIG5lY2Vzc2FyeQpzaW5jZSBhbGwgcGxhdGZvcm1zIHRoYXQgdXNl IHRoYXQgZG8gaGF2ZSBhdG9taWMgd2F0ZXJtYXJrcywgYnV0IGFkZGluZwp0aGUgY2hlY2sgY2Vy dGFpbmx5IGRvZXNuJ3QgaHVydCBhbnl0aGluZy4KCgpNYXR0Cgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA4ICsrKysrKy0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCA2IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+IGluZGV4IDc5YmY1MjcuLmQ0YjBhZDAgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTQ5NTcsNyArNDk1Nyw4IEBAIHN0YXRpYyB2b2lk IGlyb25sYWtlX2NydGNfZW5hYmxlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgCSAqLwo+ICAJ aW50ZWxfY3J0Y19sb2FkX2x1dChjcnRjKTsKPiAgCj4gLQlkZXZfcHJpdi0+ZGlzcGxheS5pbml0 aWFsX3dhdGVybWFya3MoaW50ZWxfY3J0Yy0+Y29uZmlnKTsKPiArCWlmIChkZXZfcHJpdi0+ZGlz cGxheS5pbml0aWFsX3dhdGVybWFya3MgIT0gTlVMTCkKPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5p bml0aWFsX3dhdGVybWFya3MoaW50ZWxfY3J0Yy0+Y29uZmlnKTsKPiAgCWludGVsX2VuYWJsZV9w aXBlKGludGVsX2NydGMpOwo+ICAKPiAgCWlmIChpbnRlbF9jcnRjLT5jb25maWctPmhhc19wY2hf ZW5jb2RlcikKPiBAQCAtNTA1Niw3ICs1MDU3LDEwIEBAIHN0YXRpYyB2b2lkIGhhc3dlbGxfY3J0 Y19lbmFibGUoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ICAJaWYgKCFpbnRlbF9jcnRjLT5jb25m aWctPmhhc19kc2lfZW5jb2RlcikKPiAgCQlpbnRlbF9kZGlfZW5hYmxlX3RyYW5zY29kZXJfZnVu YyhjcnRjKTsKPiAgCj4gLQlkZXZfcHJpdi0+ZGlzcGxheS5pbml0aWFsX3dhdGVybWFya3MocGlw ZV9jb25maWcpOwo+ICsJaWYgKGRldl9wcml2LT5kaXNwbGF5LmluaXRpYWxfd2F0ZXJtYXJrcyAh PSBOVUxMKQo+ICsJCWRldl9wcml2LT5kaXNwbGF5LmluaXRpYWxfd2F0ZXJtYXJrcyhwaXBlX2Nv bmZpZyk7Cj4gKwllbHNlCj4gKwkJaW50ZWxfdXBkYXRlX3dhdGVybWFya3MoY3J0Yyk7Cj4gIAlp bnRlbF9lbmFibGVfcGlwZShpbnRlbF9jcnRjKTsKPiAgCj4gIAlpZiAoaW50ZWxfY3J0Yy0+Y29u ZmlnLT5oYXNfcGNoX2VuY29kZXIpCj4gLS0gCj4gMi41LjAKPiAKCi0tIApNYXR0IFJvcGVyCkdy YXBoaWNzIFNvZnR3YXJlIEVuZ2luZWVyCklvVEcgUGxhdGZvcm0gRW5hYmxpbmcgJiBEZXZlbG9w bWVudApJbnRlbCBDb3Jwb3JhdGlvbgooOTE2KSAzNTYtMjc5NQpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK