From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next v9 00/28] package/freeswitch: new package
Date: Mon, 29 Feb 2016 22:33:07 +0100 [thread overview]
Message-ID: <20160229223307.250b8c8c@free-electrons.com> (raw)
In-Reply-To: <1456586838-21197-1-git-send-email-bernd.kuhls@t-online.de>
Bernd,
On Sat, 27 Feb 2016 16:26:50 +0100, Bernd Kuhls wrote:
> this patch series splits my previous patch into smaller chunks for easier
> review as requested by Luca and Thomas. I also removed all options from
> Config.in.
>
> Instead of enabling or disabling modules in the upstream modules.conf I
> decided to delete that file in the first patch to provide a minimal
> build for easier review, please keep in mind that I never did a run-time
> test with this minimal version. A lot of modules, desired as a default
> set, are added with the second patch - all of them have no external
> dependencies. The rest of the patch series consists of modules having
> some form of dependency, added module by module for easier review.
Thanks for this patch series. Besides my build issue and minor comments
on PATCH 01/28, it looks fine. I've looked at all other patches, and
despite a really minor nit on PATCH 26/28, I think we'll be able to
apply this once the PATCH 01/28 problems are fixed.
The fact that you did split the package addition in a minimal package
and then trivial additions of optional dependencies really made the
whole thing a lot easier to look at and review, so thanks for having
done that!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-29 21:33 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 15:26 [Buildroot] [PATCH/next v9 00/28] package/freeswitch: new package Bernd Kuhls
2016-02-27 15:26 ` [Buildroot] [PATCH/next v9 01/28] " Bernd Kuhls
2016-02-29 21:21 ` Thomas Petazzoni
2016-03-01 6:22 ` Bernd Kuhls
2016-03-01 9:18 ` Thomas Petazzoni
2016-03-01 21:02 ` Bernd Kuhls
2016-02-27 15:26 ` [Buildroot] [PATCH/next v9 02/28] package/freeswitch: enable optional modules Bernd Kuhls
2016-02-27 15:26 ` [Buildroot] [PATCH/next v9 03/28] package/freeswitch: add optional dependency to libuuid Bernd Kuhls
2016-02-27 15:26 ` [Buildroot] [PATCH/next v9 04/28] package/freeswitch: add optional dependency to libedit Bernd Kuhls
2016-02-27 15:26 ` [Buildroot] [PATCH/next v9 05/28] package/freeswitch: enable mod_enum, add optional dependency to libldns Bernd Kuhls
2016-02-27 15:26 ` [Buildroot] [PATCH/next v9 06/28] package/freeswitch: add optional dependency to libpng Bernd Kuhls
2016-02-27 15:26 ` [Buildroot] [PATCH/next v9 07/28] package/freeswitch: add optional dependency to unixodbc Bernd Kuhls
2016-02-27 15:26 ` [Buildroot] [PATCH/next v9 08/28] package/freeswitch: add optional dependency to freetype Bernd Kuhls
2016-02-27 15:26 ` [Buildroot] [PATCH/next v9 09/28] package/freeswitch: enable mod_yaml, add optional dependency to libyaml Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 10/28] package/freeswitch: enable mod_lua, add optional dependency to lua Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 11/28] package/freeswitch: enable mod_fsv, add optional dependencies to libvpx & libyuv Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 12/28] package/freeswitch: enable mod_av, add optional dependencies to ffmpeg, " Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 13/28] package/freeswitch: enable mod_vpx, add optional dependency to libvpx Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 14/28] package/freeswitch: enable mod_bv, add optional dependency to libbroadvoice Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 15/28] package/freeswitch: enable mod_codec2, add optional dependency to libcodec2 Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 16/28] package/freeswitch: add optional dependency to libg7221 Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 17/28] package/freeswitch: enable mod_ilbc, add optional dependency to libilbc Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 18/28] package/freeswitch: enable mod_isac Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 19/28] package/freeswitch: enable mod_opus, add optional dependency to opus Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 20/28] package/freeswitch: enable mod_portaudio, add optional dependency to portaudio Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 21/28] package/freeswitch: enable mod_silk, add optional dependency to libsilk Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 22/28] package/freeswitch: enable mod_sndfile, add optional dependency to libsndfile Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 23/28] package/freeswitch: enable mod_alsa, add optional dependency to alsa-lib Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 24/28] package/freeswitch: enable mod_soundtouch, add optional dependency to libsoundtouch Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 25/28] package/freeswitch: enable mod_xml_rpc Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 26/28] package/freeswitch: enable mod_imagick, add optional dependencies to imagemagick, libvpx & libyuv Bernd Kuhls
2016-02-29 21:31 ` Thomas Petazzoni
2016-03-01 21:46 ` Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 27/28] package/freeswitch: enable mod_memcache, add optional dependency to libmemcached Bernd Kuhls
2016-02-27 15:27 ` [Buildroot] [PATCH/next v9 28/28] package/freeswitch: add optional dependency to xz Bernd Kuhls
2016-02-29 21:33 ` Thomas Petazzoni [this message]
2016-02-29 21:59 ` [Buildroot] [PATCH/next v9 00/28] package/freeswitch: new package Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160229223307.250b8c8c@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.