All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: intel: remove unused variable
Date: Tue, 1 Mar 2016 11:19:27 +0530	[thread overview]
Message-ID: <20160301054858.GA3814@sudip-pc> (raw)
In-Reply-To: <20160301025912.GF18327@sirena.org.uk>

On Tue, Mar 01, 2016 at 11:59:12AM +0900, Mark Brown wrote:
> On Mon, Feb 29, 2016 at 10:53:46PM +0530, Sudip Mukherjee wrote:
> > The variable cmd_id is only assigned some value and is never used.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> 
> Your signoff doesn't correspond to your e-mail address.  While I'm
> fairly sure that you are in fact the same person so it's OK this time
> please try to ensure that they match up so that it's clear that the
> signoffs are all in order.

But it has been like this way since I started contributing.
git log --author=sudip will show you.

From: address was always sudipm.mukherjee@gmail.com
but Signed-off-by: was sudip@vectorindia.org and now
Signed-off-by: has changed to sudip.mukherjee@codethink.co.uk
and you already have many such patches from me. (well, with my
vectorindia.org email)

Can i not keep using my gmail as my From: ?
The advantage of using gmail as my From: is that the discussion and all
threads related to my patches will be in the same place even if my work
email is changed.

And AFAIK, the From: name and the Signed-off-by: name should match else
the tools used by Greg and others to generate the stats will break.

Please reconsider and let me use my gmail in my From:

regards
sudip

  reply	other threads:[~2016-03-01  5:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29 17:23 [PATCH] ASoC: intel: remove unused variable Sudip Mukherjee
2016-03-01  2:59 ` Mark Brown
2016-03-01  5:49   ` Sudip Mukherjee [this message]
2016-03-01  7:39     ` [alsa-devel] " Takashi Iwai
2016-03-02  1:02     ` Mark Brown
2016-03-02  6:26       ` Sudip Mukherjee
2016-03-02 10:56         ` Mark Brown
2016-03-02 12:27         ` One Thousand Gnomes
2016-03-02 12:27           ` One Thousand Gnomes
2016-03-02 13:07           ` Sudip Mukherjee
2016-03-02 13:42             ` Mark Brown
2016-03-02 13:42               ` Mark Brown
2016-03-02 13:20           ` Mark Brown
2016-03-02 13:53             ` One Thousand Gnomes
2016-03-02 13:53               ` One Thousand Gnomes
2016-03-02 14:04               ` Mark Brown
2016-03-02 14:04                 ` Mark Brown
2016-03-02 16:03             ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160301054858.GA3814@sudip-pc \
    --to=sudipm.mukherjee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.