Re: [oe] [PATCH] gpsd: Fix build when static libs disabled

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

On Tue, Mar 01, 2016 at 07:58:14AM +0000, Chris Trobridge wrote:
> http://lists.openembedded.org/pipermail/openembedded-devel/2016-February/106230.html
> 
> > Fix this build error:
> > SCons Error: no such option: --disable-static
> > Signed-off-by: Maxin B. John <maxin.john at intel.com>
> > ---
> >  meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb | 1 +
> >  1 file changed, 1 insertion(+)
> > diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb b/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
> > index ff268b3..a300595 100644
> > --- a/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
> > +++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
> > @@ -47,6 +47,7 @@ EXTRA_OESCONS = " \
> >      systemd='${SYSTEMD_OESCONS}' \
> >      ${EXTRA_OECONF} \
> >  "
> > +DISABLE_STATIC = ""
> >  & this cannot be used, because then chrpath is not found and only static lib is built
> >  & target=${HOST_SYS}
> >  
> > -- 
> > 2.4.0
> 
> While this fixes the build, is it just fixing the symptom?
> 
> I have a patch that copies the fix in:
> 
> http://lists.openembedded.org/pipermail/openembedded-devel/2016-February/106251.html
> 
> That is: use EXTRA_CONF_PACKAGECONFIG instead of EXTRA_OECONF, as mentioned the above diff.
> 
> This prevents the option being pulled in in the first place, which ought to be a more general solution.

Both changes depend on RFC patch from me:
http://patchwork.openembedded.org/patch/116719/
which wasn't commented on yet or merged to at least master-next.

Regards,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]