From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753130AbcCALFd (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Mar 2016 06:05:33 -0500
Received: from mx2.suse.de ([195.135.220.15]:41345 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752340AbcCALFb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Mar 2016 06:05:31 -0500
Date: Tue, 1 Mar 2016 12:05:29 +0100
From: Petr Mladek <pmladek@suse.com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Jan Kara <jack@suse.cz>,
        Peter Zijlstra <peterz@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>,
        linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH] printk/nmi: restore printk_func in nmi_panic
Message-ID: <20160301110528.GO3305@pathway.suse.cz>
References: <1456457840-1059-1-git-send-email-sergey.senozhatsky@gmail.com>
 <20160226145717.GZ12548@pathway.suse.cz>
 <20160227021944.GA1621@swordfish>
 <20160229103141.GL3305@pathway.suse.cz>
 <20160229111937.GA356@swordfish>
 <20160301092426.GA2968@swordfish>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160301092426.GA2968@swordfish>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue 2016-03-01 18:24:26, Sergey Senozhatsky wrote:
> Hello,
> 
> On (02/29/16 20:19), Sergey Senozhatsky wrote:
> [..]
> > > That is the problem. zap_locks() is not a solution.
> > > 
> > > First, it handles only lockbuf_lock and console_sem. There are other
> > > locks used by particular consoles that might cause a deadlock.
> > 
> > yes, well, that's true for panic() in general.
> 
> Petr, what do you think of this (added PRINTK_NMI_FLUSH_ON_PANIC)?
> 
> 1) zap_locks() in console_flush_on_panic()
> 2) add PRINTK_NMI_FLUSH_ON_PANIC symbols
> 3) add printk_nmi_flush_on_panic()

This is definitely better than nothing. Well, it seems that
the printk/NMI patches that motivated this patch will be
removed for a while, see
http://thread.gmane.org/gmane.linux.ports.arm.kernel/482845/focus=483002

I want to play with the panic handling a bit more and make it better
working out of box. It might be enough to put the messages into
the rind buffer when crashdump is going to be produced. Also
there is still the idea about using the lock-less early console.
I think that the solution from this patch might be the last
fallback.

Thanks a lot for proposals,
Petr